HTML code cleanup (#mw-revisiontag)
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	May 6 2008, 3:33 PM

Description

Author: Wiki.Melancholie

Description:
Please replace
<span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none; cursor:pointer;'

			onclick='toggleRevRatings()' title='zeige/verstecke Details' >(+/-)</span>

by
<a id="mw-revisiontoggle" class="flaggedrevs_toggle" href="javascript:toggleRevRatings()" title="Zeige/verstecke Details">(+/-)</a>

as this is shorter. Then do not toggle style.display, but the link text (innerHTML) ["(+/-)" <> ""]
No need then for cursor:pointer anymore!

Furthermore either use " or ' ;-) As the whole rest of the HTML output uses /"/ I would use that. Trivial, but consistent.

Version: unspecified
Severity: trivial

Details

Reference: bz13984

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:14 PM

• bzimport added a project: FlaggedRevs.

• bzimport set Reference to bz13984.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.May 6 2008, 3:33 PM

visibility is cleaner. I'll look into consistent quote use

Well, cursor: pointer; isn't supported by IE, thus some hack for cursor: hand; necessary if it can't be <a> instead of <span> which would simplify this a lot.

I'm seeing the hand over the +/- link in IE 7 at least.

Switched to <a> in r34919

Unfortunately, it seems NoScript treats <a href="javascript:foo('bar')"> and <a href="#" onclick="foo('bar')"> exactly the same way. So changing from the former to the latter won't actually fix the problem.

MediaWiki should not accomodate to crappy Firefox extensions, but they should be fixed to run properly.

<a href="#" onclick="foo('bar')"> is the correct accessible way, how to deal with javascript links only.

Sorry, wrong bug. Comment #5 above should've been to bug 16073.

HTML code cleanup (#mw-revisiontag)Closed, ResolvedPublicActions

Description

Details

Event Timeline

HTML code cleanup (#mw-revisiontag)
Closed, ResolvedPublic
Actions