[Bug] Display error in the TreeMap when embedded
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Lea_Lacroix_WMDE
	Mar 13 2017, 9:18 AM

Description

When a query viewed in TreeMap is displayed via embed.html, some problems occurs: both background color and text color are white, so the text can't be read, and other minor css problems. When displayed in the query page, no bug occurs.

Example of a query

Same example embedded

Tested on Firefox 52.0 and Chromium with same results.

Possible cause: embed.html and the main query service page doesn't use exactly the same CSS and JS. In the main page, the graph is included in a div with attributes

id="query-result" style="display: block;"

In the embed page, this div has only

id="query"

Modifying DOM and the attributes makes embed.html displaying the graph correctly.

Details

	Subject	Repo	Branch	Lines +/-
	Using same result div id in embed as main page	wikidata/query/gui	master	+3 -2

Customize query in gerrit

Related Objects

Mentioned In: rWDQGea56c803cca7: Using same result div id in embed as main page
rWDQG13d5aebe41df: Using same result div id in embed as main page

Event Timeline

Lea_Lacroix_WMDE created this task.Mar 13 2017, 9:18 AM

Restricted Application added projects: Wikidata, Discovery-ARCHIVED. · View Herald TranscriptMar 13 2017, 9:18 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

EdouardHue subscribed.Mar 13 2017, 9:21 AM

Envlh subscribed.Mar 13 2017, 11:38 AM

VIGNERON subscribed.Mar 13 2017, 8:51 PM

Change 342546 had a related patch set uploaded (by EdouardHue):
[wikidata/query/gui] Using same result div id in embed as main page

https://gerrit.wikimedia.org/r/342546

gerritbot added a project: Patch-For-Review.Mar 13 2017, 10:34 PM

Just submitted a patch. Changing div id was just a workaround, a little more hacking seems necessary.

EdouardHue mentioned this in rWDQG13d5aebe41df: Using same result div id in embed as main page.Mar 13 2017, 10:36 PM

• Jonas moved this task from Incoming to GUI on the Wikidata-Query-Service board.Mar 14 2017, 9:20 AM

• Jonas mentioned this in rWDQGea56c803cca7: Using same result div id in embed as main page.Mar 14 2017, 9:36 AM

• Jonas closed this task as Resolved.Mar 14 2017, 9:38 AM

• Jonas added a project: Wikidata-Former-Sprint-Board.

• Jonas moved this task from Proposed to Done on the Wikidata-Former-Sprint-Board board.

Change 342546 merged by jenkins-bot:
[wikidata/query/gui] Using same result div id in embed as main page