i
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Mar 19 2017, 12:36 PM

Description

I am getting this test failure when running --group Wikibase tests:

1) Wikibase\Repo\Tests\Specials\SpecialItemsWithoutSitelinksTest::testExecute
InvalidArgumentException: $idSerialization must match /^Q[1-9]\d{0,9}\z/i

/var/www/wiki/w/extensions/Wikidata/vendor/wikibase/data-model/src/Entity/ItemId.php:40
/var/www/wiki/w/extensions/Wikidata/vendor/wikibase/data-model/src/Entity/ItemId.php:28
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/repo/includes/Store/Sql/SqlItemsWithoutSitelinksFinder.php:70
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/repo/includes/Store/Sql/SqlItemsWithoutSitelinksFinder.php:63
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialItemsWithoutSitelinks.php:41
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialWikibaseQueryPage.php:113
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialItemsWithoutSitelinks.php:28
/var/www/wiki/w/tests/phpunit/includes/specials/SpecialPageExecutor.php:105
/var/www/wiki/w/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
/var/www/wiki/w/tests/phpunit/includes/specials/SpecialPageTestBase.php:69
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialItemsWithoutSitelinksTest.php:43
/var/www/wiki/w/tests/phpunit/MediaWikiTestCase.php:400
/var/www/wiki/w/maintenance/doMaintenance.php:111

Details

	Subject	Repo	Branch	Lines +/-
	Don't create property in item namespace in ReferencedEntitiesDataUpdaterTest	mediawiki/extensions/Wikibase	master	+49 -51

Customize query in gerrit

Event Timeline

aude created this task.Mar 19 2017, 12:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2017, 12:36 PM

Change 343543 had a related patch set uploaded (by Aude):
[mediawiki/extensions/Wikibase] Don't create property in item namespace in ReferencedEntitiesDataUpdaterTest

https://gerrit.wikimedia.org/r/343543

gerritbot added a project: Patch-For-Review.Mar 19 2017, 12:41 PM

aude updated the task description. (Show Details)Mar 19 2017, 12:41 PM

aude added a project: Wikidata-Former-Sprint-Board.

aude moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.

WMDE-leszek triaged this task as High priority.Mar 21 2017, 10:24 AM

Change 343543 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Don't create property in item namespace in ReferencedEntitiesDataUpdaterTest

https://gerrit.wikimedia.org/r/343543

I couldn't reproduce the test failure locally, so let me ask @aude: as that patch got merged, is this bug resolved?

think this issue only happens with items in the main namespace. Otherwise, if the main namespace is wikitext, then the property was created in the main wikitext namespace and wouldn't appear when querying for all items in the special page.

The patch indeed fixes the issue.

@aude Thanks!

think this issue only happens with items in the main namespace. Otherwise, if the main namespace is wikitext, then the property was created in the main wikitext namespace and wouldn't appear when querying for all items in the special page.

this seems a valid explanation. My setup indeed is wikitext being a main namespace.

SpecialItemsWithoutSitelinksTest::testExecute InvalidArgumentException: $idSerialization must match /^Q[1-9]\d{0,9}\z/iClosed, ResolvedPublicActions

Description

Details

Event Timeline

SpecialItemsWithoutSitelinksTest::testExecute InvalidArgumentException: $idSerialization must match /^Q[1-9]\d{0,9}\z/i
Closed, ResolvedPublic
Actions