Page MenuHomePhabricator

Template changes get autoflagged after a revert is autoflagged
Closed, DeclinedPublic

Description

This bug seems to be a result of the fix of Bug 13978 (Reverting to a flagged revision should automatically mark the resulting revision as flagged, too).

In the following situation, changes to templates get autoflagged without anyone checking them:

  1. article with latest flagged version exist, but it has a template that needs to be flagged
  2. Vandal does nasty edit
  3. Edit gets reverted and revert edit autoflagged because article was flagged at 1.

A picture is worth a thousand words:
http://img259.imageshack.us/img259/5719/bugtemplatesgetautosighcz3.png

I propose not to pay too much attention to this bug; a real management of flaggedrevs on templates is needed (imho). This bug report is just for your information.


Version: unspecified
Severity: minor

Details

Reference
bz14250

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:12 PM
bzimport set Reference to bz14250.

This was discussed a lot in the mailing list. It is not likely to matter, and the template/image review solution will be enabled shortly (I've just been testing and improve it recently, the code is old).