Page MenuHomePhabricator
Create Task
Maniphest T164847

Striker gives fatal error when a SUL account already in use tries to attach to a second LDAP account
Closed, ResolvedPublic
Actions

Description

Error saving OAuth credentials. [req id: f1a2370b1b8a4e1a8827de96b9bce144]

When trying to connect a second Tools Labs account to the main Wikimedia account through OAuth, I get this error message every time I do it. I believe this is a bug, even though the connection of two accounts to one Wikimedia account is not possible.

Details

SubjectRepoBranchLines +/-
Tool account creation and morelabs/striker/deploymaster+234 -3
Show message when duplicate SUL attach occurslabs/strikermaster+9 -0
Customize query in gerrit

Related Objects

Event Timeline

FriyMan created this task.May 9 2017, 3:37 PM
Restricted Application added a project: User-bd808. · View Herald TranscriptMay 9 2017, 3:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
bd808 added projects: Striker, Toolforge.May 9 2017, 4:08 PM

Gergo looked this up in logstash and found _mysql_exceptions.IntegrityError: (1062, "Duplicate entry 'FriyMan' for key 'sulname'"). Only being allowed to associate a SUL account with a single LDAP account is expected, but this should give the user a nice notice that the account is already in use rather than a fatal error.

Restricted Application added a project: Cloud-Services. · View Herald TranscriptMay 9 2017, 4:08 PM
Framawiki subscribed.May 9 2017, 6:39 PM
Aklapper removed a project: (DEPRECATED) Bug-Report.May 9 2017, 6:58 PM
bd808 mentioned this in T164849: Detachment of an account on Tool Labs from the Main wikimedia account. .May 10 2017, 7:12 PM
bd808 added a project: cloud-services-team (Kanban).May 19 2017, 1:34 PM
gerritbot subscribed.Jul 10 2017, 12:45 AM

Change 364140 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker@master] Show message when duplicate SUL attach occurs

https://gerrit.wikimedia.org/r/364140

gerritbot edited projects, added Patch-For-Review; removed Toolforge, Cloud-Services.Jul 10 2017, 12:45 AM
bd808 moved this task from Inbox to Doing on the cloud-services-team (Kanban) board.Jul 10 2017, 12:45 AM
bd808 moved this task from Backlog to Doing on the Striker board.Jul 10 2017, 3:35 AM
bd808 added a subscriber: Bergognone.Jul 10 2017, 10:46 PM

Lots of this in the logs today:
_mysql_exceptions.IntegrityError: (1062, "Duplicate entry 'Bergognone' for key 'sulname'")

Sorry @Bergognone, only one LDAP account per SUL account is currently allowed.

Andrew triaged this task as Medium priority.Jul 24 2017, 3:35 PM
bd808 renamed this task from Error saving OAuth credentials. [req id: f1a2370b1b8a4e1a8827de96b9bce144] bug to Striker gives fatal error when a SUL account already in use tries to attach to a second LDAP account.Jul 24 2017, 3:40 PM
bd808 updated the task description. (Show Details)
gerritbot added a comment.Aug 13 2017, 7:17 PM

Change 364140 merged by BryanDavis:
[labs/striker@master] Show message when duplicate SUL attach occurs

https://gerrit.wikimedia.org/r/364140

gerritbot added a comment.Aug 13 2017, 7:39 PM

Change 370139 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker/deploy@master] Tool account creation and more

https://gerrit.wikimedia.org/r/370139

gerritbot added a comment.Aug 23 2017, 3:32 PM

Change 370139 merged by jenkins-bot:
[labs/striker/deploy@master] Tool account creation and more

https://gerrit.wikimedia.org/r/370139

Stashbot mentioned this in T128400: Unable to add service group to service groups.Aug 23 2017, 4:23 PM
Stashbot mentioned this in T149458: Manage shared tool accounts via Striker.
Stashbot mentioned this in T159044: Replace deprecated phabricator conduit api calls in phabricator.py file.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-08-23T16:23:46Z] <bd808@tin> Started deploy [striker/deploy@2f2dd7c]: Deploying 2f2dd7c "Tool account creation and more" (T128400, T149458, T159044, T164847, T167931, T168480, T173845)

Stashbot mentioned this in T167931: Fatal error when adding a duplicate SSH key.Aug 23 2017, 4:23 PM
Stashbot mentioned this in T168480: Perform core Cloud Services rebranding.
Stashbot mentioned this in T173845: Make potential for others to see IP Address for ssh sessions explicit in Toolforge membership request process.

Mentioned in SAL (#wikimedia-operations) [2017-08-23T16:24:26Z] <bd808@tin> Finished deploy [striker/deploy@2f2dd7c]: Deploying 2f2dd7c "Tool account creation and more" (T128400, T149458, T159044, T164847, T167931, T168480, T173845) (duration: 00m 39s)

bd808 closed this task as Resolved.Aug 23 2017, 5:52 PM

Now gives the error message "Wikimedia unified account is already in use."

bd808 moved this task from Doing to Done on the cloud-services-team (Kanban) board.Aug 24 2017, 12:58 AM
bd808 moved this task from Doing to Done on the Striker board.Aug 24 2017, 7:29 PM
bd808 moved this task from To Do to Done on the User-bd808 board.Jul 15 2020, 9:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits