Correct uniques computation to not exclude countries that don't have either underestimates or offset
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	JAllemandou
	May 18 2017, 11:13 AM

Description

Currently we join underestimates and offset using an INNER JOIN, meaning we lose data in case there is no underestimates or no offsets.

These is of little effect on data as it only affects projects with a very small number of uniques (and we know the data quality is lower for uniques <1000 so we recommend it is not used for those). See: https://wikitech.wikimedia.org/wiki/Analytics/Data_Lake/Traffic/Unique_Devices/Last_access_solution#Data_Quality_Analysis

	Subject	Repo	Branch	Lines +/-
	Correct last_access_uniques daily/monthly bug	analytics/refinery	master	+2 -2
	Correct last uniques oozie jobs (wrong join)	analytics/refinery	master	+34 -22

Mentioned In: T143928: Count project-wide unique devices (like *.wikipedia.org)

Change 354214 had a related patch set uploaded (by Joal; owner: Joal):
[analytics/refinery@master] Correct last uniques oozie jobs (wrong join)

JAllemandou set the point value for this task to 3.

Change 354214 merged by Joal:
[analytics/refinery@master] Correct last uniques oozie jobs (wrong join)

Change 355387 had a related patch set uploaded (by Joal; owner: Joal):
[analytics/refinery@master] Correct last_access_uniques daily/monthly bug

Change 355387 merged by Joal:
[analytics/refinery@master] Correct last_access_uniques daily/monthly bug