Represent order of CollaborationListContent entries based on order of appearance in original JSON
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Harej
	May 18 2017, 1:06 PM

Description

Follow-up to https://phabricator.wikimedia.org/rECKTd97f07fdf7d7cfb20a682edcb3e5bf1557d39475

Item IDs are assigned based on the order *once they are sorted*. This is not necessarily the same as the order in JSON; in fact it is only the same if "natural" sorting is used. (Member lists do not use natural sorting but do a totally different thing altogether.) The approach to assigning item IDs should be revisited, or we should have a second ID representing the canonical ordering in the JSON.

Details

	Subject	Repo	Branch	Lines +/-
	Fix edit conflict handling in lists.	mediawiki/extensions/CollaborationKit	master	+28 -2
	Assign column-agnostic UID to individual list entries	mediawiki/extensions/CollaborationKit	master	+221 -150

Customize query in gerrit

Related Objects

Mentioned In: rECKT9d5d29a0e0aa: Fix edit conflict handling in lists.
rECKT34a62b6549a9: Fix edit conflict handling in lists.
rECKTb855d20a9fb3: Fix edit conflict handling in lists.
rECKTe87716195a43: Fix edit conflict handling in lists.
rECKT8094b3a7c857: Assign column-agnostic UID to individual list entries
rECKTe7f7905769ca: Assign column-agnostic UID to individual list entries
rECKT9f75a67c7ddf: Assign column-agnostic UID to individual list entries
rECKT2fd35241484e: Assign column-agnostic UID to individual list entries
rECKT3d7ce1177c09: Assign column-agnostic UID to individual list entries

Event Timeline

Harej created this task.May 18 2017, 1:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2017, 1:06 PM

Change 354618 had a related patch set uploaded (by Harej; owner: Harej):
[mediawiki/extensions/CollaborationKit@master] Assign column-agnostic UID to individual list entries

https://gerrit.wikimedia.org/r/354618

gerritbot added a project: Patch-For-Review.May 20 2017, 6:41 AM

Harej mentioned this in rECKT3d7ce1177c09: Assign column-agnostic UID to individual list entries.May 20 2017, 6:45 AM

Harej mentioned this in rECKT2fd35241484e: Assign column-agnostic UID to individual list entries.

Harej mentioned this in rECKT9f75a67c7ddf: Assign column-agnostic UID to individual list entries.May 20 2017, 6:48 AM

Harej moved this task from Release blockers to In Progress on the MediaWiki-extensions-CollaborationKit board.May 20 2017, 7:44 AM

Harej mentioned this in rECKTe7f7905769ca: Assign column-agnostic UID to individual list entries.May 20 2017, 9:39 AM

Bawolff mentioned this in rECKT8094b3a7c857: Assign column-agnostic UID to individual list entries.May 20 2017, 10:44 AM

Change 354618 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Assign column-agnostic UID to individual list entries

https://gerrit.wikimedia.org/r/354618

An additional patch is needed to fix edit conflict detection.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 20 2017, 12:00 PM

Change 354745 had a related patch set uploaded (by Brian Wolff; owner: Brian Wolff):
[mediawiki/extensions/CollaborationKit@master] Fix edit conflict handling in lists.

https://gerrit.wikimedia.org/r/354745

Bawolff mentioned this in rECKTe87716195a43: Fix edit conflict handling in lists..May 20 2017, 5:16 PM

Bawolff mentioned this in rECKTb855d20a9fb3: Fix edit conflict handling in lists..May 20 2017, 5:48 PM

Bawolff mentioned this in rECKT34a62b6549a9: Fix edit conflict handling in lists..May 20 2017, 5:51 PM

Bawolff mentioned this in rECKT9d5d29a0e0aa: Fix edit conflict handling in lists..May 20 2017, 5:55 PM

Change 354745 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Fix edit conflict handling in lists.

https://gerrit.wikimedia.org/r/354745

Harej moved this task from In Progress to Done on the MediaWiki-extensions-CollaborationKit board.May 20 2017, 6:04 PM

Harej closed this task as Resolved.Jun 15 2017, 7:42 AM