Page MenuHomePhabricator

Represent order of CollaborationListContent entries based on order of appearance in original JSON
Closed, ResolvedPublic

Description

Follow-up to https://phabricator.wikimedia.org/rECKTd97f07fdf7d7cfb20a682edcb3e5bf1557d39475

Item IDs are assigned based on the order *once they are sorted*. This is not necessarily the same as the order in JSON; in fact it is only the same if "natural" sorting is used. (Member lists do not use natural sorting but do a totally different thing altogether.) The approach to assigning item IDs should be revisited, or we should have a second ID representing the canonical ordering in the JSON.

Event Timeline

Harej created this task.May 18 2017, 1:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2017, 1:06 PM

Change 354618 had a related patch set uploaded (by Harej; owner: Harej):
[mediawiki/extensions/CollaborationKit@master] Assign column-agnostic UID to individual list entries

https://gerrit.wikimedia.org/r/354618

Change 354618 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Assign column-agnostic UID to individual list entries

https://gerrit.wikimedia.org/r/354618

An additional patch is needed to fix edit conflict detection.

Change 354745 had a related patch set uploaded (by Brian Wolff; owner: Brian Wolff):
[mediawiki/extensions/CollaborationKit@master] Fix edit conflict handling in lists.

https://gerrit.wikimedia.org/r/354745

Change 354745 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Fix edit conflict handling in lists.

https://gerrit.wikimedia.org/r/354745

Harej closed this task as Resolved.Jun 15 2017, 7:42 AM