Page MenuHomePhabricator

#globalWrapper class is not applied correctly when specific page content is entered
Closed, ResolvedPublic

Description

Author: aik.bold

Description:
Class #globalWrapper in main.css doesn't get applied to menu in Monobook skin (left page part, where sidebar is drawn), when page is consitent of such text:

    • Bad Page: BEGIN --------------------------
  • list element {{TipBox|tip content}}
    • Bad Page: END --------------------------
  • TipBox Template: BEGIN-------------------

<div>
bad div thing
</div>

  • TipBox Template: END-------------------

Please review 2 screenshots attached (in zip file). Red circles indicate where is problem in layout. Green circles indicate what layout should be.


Version: 1.12.x
Severity: normal
OS: Windows XP
Platform: PC

Details

Reference
bz14582

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:13 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz14582.
bzimport added a subscriber: Unknown Object (MLST).

aik.bold wrote:

screenshots how it is broken and how it should be.

Attached:

aik.bold wrote:

I've compare resulting HTML:

  • GOOD: BEGIN ----------------

<ul><li> list element <div>bad div thing</div>
</li></ul>

  • GOOD: END ----------------
  • BAD: BEGIN ----------------

<ul><li> list element <div>
</li></ul>
<p>bad div thing
</p>
</div>

  • BAD: END ----------------

Enter after div (in bad case) becomes list end and div closing element (</div>) are places after closing list element (</ul>). I think this is some kind of fundamental (because wiki-text is based on enters very much) problem and can't be easily fixed :(

Two ways to fix:

Use either HTML markup for list, thus

<ul>
<li>list element {{TipBox|tip content}}</li>
</ul>

or do not wrap lines in the template content, thus

<div>bad div thing</div>

aik.bold wrote:

2nd look good for me. 10x