Page MenuHomePhabricator

Cleanup Minerva/Mobile variables
Closed, ResolvedPublic

Description

Currently we have a minerva.less folder
Many of the variables inside here are generic and would be better kept in core (Wikimedia base less)
Many of the variables in here are specific to Minerva and should not be kept for generic components which can be used outside of the skin (they are not in practice but could be)

Checklist

  • Create mobile.less and minerva.less importables
  • Remove unused variables
  • ag minerva.variables resources/mobile.* should show no results
  • ag minerva.mixins resources/mobile.* should show no results

Event Timeline

Change 357671 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Cleanup mobile.less and minerva.less mixins/variables

https://gerrit.wikimedia.org/r/357671

Change 357671 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: Consolidate all the usages of @contentMargin/Padding

https://gerrit.wikimedia.org/r/357671

Jdlrobson claimed this task.