Page MenuHomePhabricator
Create Task
Maniphest T168072

Create jobs in job queue for sending email notification
Closed, ResolvedPublic
Actions

Description

Here are the reasons why we should use job queue:

  • send notification is NOT urgent job. It could be done by the job runner.
  • for popular categories (which has a lot watchers), this email sending process could drag down performance significantly!

I need do some research on this... It will have more sub-tasks for this.

Details

SubjectRepoBranchLines +/-
add Echo supportmediawiki/extensions/CategoryWatchmaster+918 -471
Customize query in gerrit

Related Objects

Event Timeline

Seanchen created this task.Jun 16 2017, 2:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2017, 2:43 PM
MarkAHershberger subscribed.Aug 26 2017, 3:06 PM

Any progress on this?

MarkAHershberger added a comment.Feb 26 2018, 1:06 PM

I've added integration with Echo that could close this.

gerritbot subscribed.Feb 26 2018, 1:08 PM

Change 386007 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/extensions/CategoryWatch@master] add Echo support

https://gerrit.wikimedia.org/r/386007

gerritbot added a project: Patch-For-Review.Feb 26 2018, 1:08 PM
MarkAHershberger mentioned this in rECWAf640c0fa3f94: add Echo support.Feb 26 2018, 1:11 PM
gerritbot added a comment.Mar 7 2018, 4:39 PM

Change 386007 merged by Seanchenldap:
[mediawiki/extensions/CategoryWatch@master] add Echo support

https://gerrit.wikimedia.org/r/386007

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:02 PM
Aklapper added a comment.Mar 25 2020, 2:19 PM

@Seanchen: Hi, the patch in Gerrit has been merged. Can this task be resolved (via Add Action... → Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!

Aklapper closed this task as Resolved.May 17 2020, 10:07 AM
Aklapper reassigned this task from Seanchen to MarkAHershberger.

@Seanchen: No reply, hence assuming this is resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits