Page MenuHomePhabricator

Validation error when field is mandatory and input type=radiobuttons
Closed, ResolvedPublic

Description

Author: matthewdw

Description:
HTML output from the form definition in the Description

See attached form definition and produced output. The generated javascript searches for an element with ID "input_2" (line 191), but that doesn't exist, because it's a radiobutton field with a different name, so the validation function errors on line 76.

It seems that you're at least supposed to be able to specify "mandatory" for a radiobutton control, because doing so eliminates the "None" option that otherwise appears. Ideally, I'd like to be able to specify "mandatory|input type=radiobutton|default=AKeywordOrNotOneOfTheValues", in which case the validation would make the user explicitly select a radio button, rather than having a default selected...but that might constitute a feature request. Right now it seems putting mandatory on the radiobutton control is broken, I'm not sure what the intended behavior is.

Form Definition:

{{{info|page name=Radar Checklist <Radar Checklist[timestamp]>|add title=Complete Radar Checklist}}}

{{{for template|Radar Checklist}}}
<table class="wikitable">
<tr><th colspan=2>Operational Status</th></tr>
<tr>

<td>Time Check (+/- 3min)</td>
<td>{{{field|timecheck|mandatory|input type=radiobutton}}}</td>

</tr>
<tr>

<td>RDA Power</td>
<td>{{{field|rdapower|mandatory}}}</td>

</tr>
<tr>

<td>Generator Fuel Level</td>
<td>{{{field|fuel|mandatory}}}%</td>

</tr>
<tr>

<td>VCP Selected</td>
<td>{{{field|vcp|mandatory}}}</td>

</tr>
<tr><th colspan=2>Communications Lines</th></tr>
<tr>

<td>Line 21 (FAA ZLC) Connected</td>
<td>{{{field|line21|mandatory|input type=radiobutton}}}</td>

</tr>
<tr>

<td>Line 25 (AWIPS) Connected</td>
<td>{{{field|line25|mandatory|input type=radiobutton}}}</td>

</tr>
<tr><th colspan=2>Environmental Data</th></tr>
<tr>

<td>0 Deg Height</td>
<td>{{{field|0deg|mandatory}}} KFeet</td>

</tr>
<tr>

<td>-20 Deg Height</td>
<td>{{{field|20deg|mandatory}}} KFeet</td>

</tr>
<tr><th colspan=2>Data Availability</th></tr>
<tr>

<td>BDDS (Archive II) KSFX Green</td>
<td>{{{field|bdds|mandatory|input type=radiobutton}}}</td>

</tr>
<tr>

<td>AWIPS D2D KSFX Current</td>
<td>{{{field|ksfxcurrent|mandatory|input type=radiobutton}}}</td>

</tr>
<tr>

<td>AWIPS D2D KMTX Current</td>
<td>{{{field|kmtxcurrent|mandatory|input type=radiobutton}}}</td>

</tr>
</table>

Date/Time: {{{field|timestamp|mandatory|input type=datetime}}}
{{{end template}}}


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz14838

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:09 PM
bzimport set Reference to bz14838.

Hi, sorry for the long delay. Is this still an issue?

I believe that this is fixed in version 1.3.1. Feel free to re-open this bug if it's still not working correctly.