Page MenuHomePhabricator

revscoring train_model dies without --observations
Closed, ResolvedPublic

Description

This looks like a mistake, since there's supposed to be a default value.

cat datasets/enwiki.draft_quality.201508-201608.10k.with_cache.json | \                           
revscoring train_model \                         
  revscoring.scorer_models.GradientBoosting \    
  draftquality.feature_lists.enwiki.draft_quality \                                               
  -p 'learning_rate=0.01' \                      
  -p 'max_features="log2"' \                     
  -p 'max_depth=7' \    
  -p 'n_estimators=700' \                        
  --version 0.0.1 > models/enwiki.draft_quality.gradient_boosting.model                           
Traceback (most recent call last):               
  File "/home/awight/draftquality/.env/bin/revscoring", line 11, in <module>                      
    sys.exit(main())    
  File "/home/awight/draftquality/.env/lib/python3.4/site-packages/revscoring/revscoring.py", line 53, in main            
    module.main(sys.argv[2:])                    
  File "/home/awight/draftquality/.env/lib/python3.4/site-packages/revscoring/utilities/train_model.py", line 85, in main 
    if args['--observations'] == "<stdin>":      
KeyError: '--observations'