Page MenuHomePhabricator

Add results of compilation with the future parser to the puppet compiler
Closed, ResolvedPublic

Description

We need to make all of our puppet manifests able to be compiled with both the traditional and the future puppet parser.

While at the moment it is possible to do this by adding a .configs file to the change, that won't work now that we want to sistematically check changes with the future parser.

So do the following:

  • for every compiler run, compile the change with the future parser as well, save the produced files
  • when both the normal run and the one with the future parser work correctly, check the resulting catalog for diffs, add a link to it in the host page
  • if a parameter is defined in the CI job, run in "check for future mode", and report success only if the change compiles with both parsers with no diffs with production.

Since we will expect future parser to run in the "future" environment, this depends on directory environments being available.

Event Timeline

Joe triaged this task as Medium priority.
Joe added projects: Puppet CI, User-Joe.
Joe updated the task description. (Show Details)

Change 363808 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/software/puppet-compiler@master] Add future parser run mode

https://gerrit.wikimedia.org/r/363808

Change 363808 merged by Giuseppe Lavagetto:
[operations/software/puppet-compiler@master] Add future parser run mode

https://gerrit.wikimedia.org/r/363808

Change 365555 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/puppet@production] puppet-compiler: bump to code version 0.2.0

https://gerrit.wikimedia.org/r/365555

Change 365555 merged by Giuseppe Lavagetto:
[operations/puppet@production] puppet-compiler: bump to code version 0.2.0

https://gerrit.wikimedia.org/r/365555