Page MenuHomePhabricator

Tool "matthewrbowker-dev" loads bootstrap from bootstrapcdn
Closed, ResolvedPublic

Description

https://tools.wmflabs.org/matthewrbowker-dev/: https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/css/bootstrap.min.css
https://tools.wmflabs.org/matthewrbowker-dev/: https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/js/bootstrap.min.js

Loading from external providers are discouraged. Please see parent tasks and J65.
In your case a direct replacement would be:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2017, 11:08 PM
Matthewrbowker closed this task as Invalid.Aug 7 2017, 6:37 PM

Already fixed on my local dev tools, I have just been really bad at git and deploying fixes there

zhuyifei1999 reopened this task as Open.Aug 7 2017, 8:05 PM

Still not fixed at the moment:

$ curl https://tools.wmflabs.org/matthewrbowker-dev/ -s | grep bootstrapcdn
    <link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/css/bootstrap.min.css" rel="stylesheet"
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/js/bootstrap.min.js"

Whether it is fixed locally or now is outside the scope of this task. This task concerns pages under schema http/https, domain tools.wmflabs.org, and path under /matthewrbowker-dev only.

Matthewrbowker closed this task as Resolved.Aug 7 2017, 8:21 PM