ArticleFeedbackV5 error when upgrading to 1.29
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	Reception123
	Aug 8 2017, 6:30 AM

Description

Version: 1.29 (REL1_29)
PHP: 5.6

When trying to edit and save something on the Main Page with ArticleFeedbackV5 enabled getting exception and:

2017-08-08 06:24:30 test1 test1wiki: [] /w/index.php?title=Main_Page&action=submit   MWException from line 176 of /srv/mediawiki/w/includes/Hooks.php: Invalid callback ArticleFeedbackv5Hooks::editAttempt in hooks for EditPage::attemptSave

#0 /srv/mediawiki/w/includes/EditPage.php(1741): Hooks::run(string, array)
#1 /srv/mediawiki/w/includes/EditPage.php(1493): EditPage->internalAttemptSave(NULL, boolean)
#2 /srv/mediawiki/w/includes/EditPage.php(637): EditPage->attemptSave(NULL)
#3 /srv/mediawiki/w/includes/actions/EditAction.php(59): EditPage->edit()
#4 /srv/mediawiki/w/includes/actions/SubmitAction.php(38): EditAction->show()
#5 /srv/mediawiki/w/includes/MediaWiki.php(499): SubmitAction->show()
#6 /srv/mediawiki/w/includes/MediaWiki.php(293): MediaWiki->performAction(Article, Title)
#7 /srv/mediawiki/w/includes/MediaWiki.php(862): MediaWiki->performRequest()
#8 /srv/mediawiki/w/includes/MediaWiki.php(523): MediaWiki->main()
#9 /srv/mediawiki/w/index.php(43): MediaWiki->run()
#10 {main}

Related Objects

Mentioned Here: T160801: Consider what to do with ClickTracking and work-in-progress EventLogging leftover in ArticleFeedbackv5

Event Timeline

Reception123 created this task.Aug 8 2017, 6:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2017, 6:30 AM

@Reception123 Hi, thanks for reporting this. You should be using the master branch for ArticleFeedbackv5 (as a general heads-up, this also generally applies to extensions managed by ShoutWiki developers. Sorry for not clearing that up before)

Those hooks were removed in https://gerrit.wikimedia.org/r/#/c/356981/ as a follow-up to https://gerrit.wikimedia.org/r/#/c/343427/ (that part got accidentally overlooked). So if you use master, there should be nothing firing those hooks. (Those hooks were only used to log AFTv5 events, but those logs weren't useful anymore per T160801: Consider what to do with ClickTracking and work-in-progress EventLogging leftover in ArticleFeedbackv5 ).

I'm going to mark this as invalid now. Thanks!

Thank you @SamanthaNgyuen

ArticleFeedbackV5 error when upgrading to 1.29Closed, InvalidPublicActions

Description

Related Objects

Event Timeline

ArticleFeedbackV5 error when upgrading to 1.29
Closed, InvalidPublic
Actions