⚓ T172948 Desktop Minerva main edit icon sometimes points to section 1

Subject	Repo	Branch	Lines +/-
Fix editing of non-mobile-formatted pages	mediawiki/skins/MinervaNeue	master	+7 -3
Page.js getLeadSectionElement returns page element when no sections located	mediawiki/extensions/MobileFrontend	master	+68 -7
Correctly identify the lead section	mediawiki/skins/MinervaNeue	master	+8 -5
Do not try to enable toggling if using desktop Minerva	mediawiki/skins/MinervaNeue	master	+4 -0

Jdlrobson created this task.Aug 9 2017, 8:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2017, 8:32 PM

Jdlrobson mentioned this in T157995: Impossible to edit pages without sections on Minerva skin (including all pages in desktop Minerva).Aug 9 2017, 8:32 PM

Change 370087 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Page.js getLeadSectionElement returns page element when no sections located

https://gerrit.wikimedia.org/r/370087

Change 369934 had a related patch set uploaded (by Jdlrobson; owner: Bmansurov):
[mediawiki/skins/MinervaNeue@master] Correctly identify the lead section

https://gerrit.wikimedia.org/r/369934

Jdlrobson moved this task from Untriaged to Discuss further on the Web-Team-Backlog-Archived (Tracking) board.Aug 10 2017, 4:20 PM

Jdlrobson mentioned this in T171488: Desktop Minerva accidentally enables section collapsing on certain sections.Aug 16 2017, 6:54 PM

Jdlrobson updated the task description. (Show Details)Aug 17 2017, 10:03 PM

Jdlrobson updated the task description. (Show Details)Aug 17 2017, 10:11 PM

Change 373914 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Do not try to enable toggling if using desktop Minerva

https://gerrit.wikimedia.org/r/373914

Change 373914 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Do not try to enable toggling if using desktop Minerva

https://gerrit.wikimedia.org/r/373914

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)).Aug 25 2017, 4:00 PM

Jdlrobson removed a project: Patch-For-Review.Aug 25 2017, 4:20 PM

Change 369934 abandoned by Bmansurov:
Correctly identify the lead section

Reason:
busy with other stuff

https://gerrit.wikimedia.org/r/369934

Change 370087 abandoned by Jdlrobson:
Page.js getLeadSectionElement returns page element when no sections located

https://gerrit.wikimedia.org/r/370087

Jdlrobson updated the task description. (Show Details)Sep 27 2017, 9:07 PM

Jdlrobson renamed this task from Various issues with Minerva due to lack of MobileFormatter on desktop to Various issues with Minerva due to lack of lead section provided by MobileFormatter on desktop.Nov 22 2017, 5:58 PM

Jdlrobson edited projects, added Web-Team-Backlog-Archived; removed Web-Team-Backlog-Archived (Tracking).Jan 12 2018, 8:03 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Jan 12 2018, 8:12 PM

Jdlrobson moved this task from Incoming to Epics/Goals on the Web-Team-Backlog-Archived board.Jan 17 2018, 5:26 PM

Jdlrobson moved this task from Epics/Goals to Needs Prioritization on the Web-Team-Backlog-Archived board.

Jdlrobson renamed this task from Various issues with Minerva due to lack of lead section provided by MobileFormatter on desktop to [Tracking] Various issues with Minerva due to lack of lead section provided by MobileFormatter on desktop.Jan 29 2018, 6:29 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson merged a task: T185832: Problems in it.wiki namespace "Template".

Jdlrobson added subscribers: Ignazio, Kizule.

Change 406628 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Fix editing of non-mobile-formatted pages

https://gerrit.wikimedia.org/r/406628

gerritbot added a project: Patch-For-Review.Jan 29 2018, 7:16 PM

Change 406628 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix editing of non-mobile-formatted pages

https://gerrit.wikimedia.org/r/406628

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 29 2018, 10:00 PM

Jdlrobson renamed this task from [Tracking] Various issues with Minerva due to lack of lead section provided by MobileFormatter on desktop to Page issues do not show in Minerva desktop.Feb 7 2018, 6:10 PM

Jdlrobson removed a project: Patch-For-Review.

Jdlrobson updated the task description. (Show Details)

Jdlrobson renamed this task from Page issues do not show in Minerva desktop to Desktop Minerva main edit icon sometimes points to section 1.Feb 7 2018, 7:03 PM

Jdlrobson updated the task description. (Show Details)

ovasileva triaged this task as Medium priority.Feb 13 2018, 3:49 PM

This appears to be fixed now, thanks to https://gerrit.wikimedia.org/r/406628

• Phabricator_maintenance moved this task from Needs Prioritization to 2017-18 Q3 on the Web-Team-Backlog-Archived board.Mar 7 2018, 4:44 AM

Jdlrobson mentioned this in T197834: Regression: Editing workflow broken for non-JS users and template editors on mobile.Jun 20 2018, 10:49 PM

Desktop Minerva main edit icon sometimes points to section 1
Closed, ResolvedPublic
Actions

Description

Sign off

Details

Related Objects

Event Timeline

Desktop Minerva main edit icon sometimes points to section 1Closed, ResolvedPublicActions

Description

Sign off

Details

Related Objects

Event Timeline

Desktop Minerva main edit icon sometimes points to section 1
Closed, ResolvedPublic
Actions