Don't hard-code page title in 'restore prefs' link construction
Closed, ResolvedPublic
Actions

Description

The PreferencesForm::getButtons() method currently hard codes the page name (Preferences) when constructing the "Restore all default settings (in all sections)" link. This breaks subclasses of PreferencesForm.

Details

	Subject	Repo	Branch	Lines +/-
	Don't hard-code Preferences page name	mediawiki/core	master	+1 -1

Customize query in gerrit

Event Timeline

Samwilson created this task.Aug 21 2017, 2:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2017, 2:09 AM

Change 372805 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Don't hard-code Preferences page name

https://gerrit.wikimedia.org/r/372805

gerritbot added a project: Patch-For-Review.Aug 21 2017, 2:10 AM

Samwilson claimed this task.Aug 21 2017, 2:11 AM

Samwilson added a project: MediaWiki-extensions-GlobalPreferences.

Change 372805 merged by jenkins-bot:
[mediawiki/core@master] Don't hard-code Preferences page name

https://gerrit.wikimedia.org/r/372805

Samwilson closed this task as Resolved.Aug 21 2017, 10:43 PM

Samwilson added a project: Community-Tech-Sprint.

Samwilson moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 21 2017, 11:00 PM

• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Aug 31 2017, 12:33 AM

• DannyH moved this task from New & TBD Tickets to Archive on the Community-Tech board.

Don't hard-code page title in 'restore prefs' link constructionClosed, ResolvedPublicActions

Description

Details

Event Timeline

Don't hard-code page title in 'restore prefs' link construction
Closed, ResolvedPublic
Actions