Page MenuHomePhabricator

Some messages are not displayed in any languages
Closed, ResolvedPublic

Description

Reproduce:

  1. https://query.wikidata.org/
  2. use any language

In query helper shows "wdqs-ve-filter" and "wdqs-ve-show"

See also:
T173662: Apply correct fallback for messages displayed on interface
T174463: No message display in languages with variant

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 406301 had a related patch set uploaded (by Li Song; owner: Li Song):
[wikidata/query/gui@master] Fix jquery.i18n language fallback

https://gerrit.wikimedia.org/r/406301

Change 406301 merged by jenkins-bot:
[wikidata/query/gui@master] Fix jquery.i18n language fallback

https://gerrit.wikimedia.org/r/406301

Change 406321 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/gui-deploy@production] Merging from 0bdc656e1f10af4baa8821ee7ef07dfd843ced06:

https://gerrit.wikimedia.org/r/406321

Change 406321 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 0bdc656e1f10af4baa8821ee7ef07dfd843ced06:

https://gerrit.wikimedia.org/r/406321

Hi @Lucas_Werkmeister_WMDE , thanks for review the patch yesterday! I'm wonder how often do we deploy the site?

Just wants to make sure the production also works fine :D And we may be able to close (some) tickets here after then

I’m not sure how often we deploy in general, but I think it should be deployed now according to @gerritbot’s comments above.

@Lucas_Werkmeister_WMDE

That's weird.. The production site is not working, and it seems that the compilse js still have the `+ lang.json``` thing inside

.load("i18n/"+this.language+".json",this.language)),t.when(r,t.i18n().load("i18n/"+e+".json",e))}

From

https://query.wikidata.org/js/wdqs.min.a590db3ff857fa708077.js

any idea?

Hm, it’s possible that it will only be deployed with the next “Wikidata Query Service weekly deploy” window, which starts today at 18:00 UTC… I’m not sure how WDQS deploys work.

WDQS deployment window is on Monday 10-10:30 PST. The deployment schedule is at https://wikitech.wikimedia.org/wiki/Deployments

Smalyshev triaged this task as Medium priority.Jan 29 2018, 6:06 PM
Smalyshev edited projects, added Wikidata Query UI; removed Wikidata-Query-Service.

Thanks @Smalyshev

I think now it's deployed...but somehow the language json files for some langs it's not acciessbale(return 404), For example:

https://query.wikidata.org/i18n/sr-ec.json
https://query.wikidata.org/i18n/zh-hans.json
https://query.wikidata.org/i18n/en-gb.json

And I found the cause it's actually in the build process, where the plugin rename the langauge file name... I'll send a patch later

Change 406996 had a related patch set uploaded (by Zoranzoki21; owner: Li Song):
[wikidata/query/gui@master] Fix missing i18n language json files in the build process.

https://gerrit.wikimedia.org/r/406996

Change 406996 merged by jenkins-bot:
[wikidata/query/gui@master] Fix missing i18n language json files in the build process.

https://gerrit.wikimedia.org/r/406996

Smalyshev claimed this task.