Page MenuHomePhabricator
Create Task
Maniphest T175816

Editing of <gallery>: Percent encoding filenames not recognized
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce

  • Open example page with VisualEditor mode
  • Edit the gallery with 3 images
  • In gallery you see only 2 images. The image with percent encoded filename "Przej%C5%9Bcie_graniczne_U%C5%BChorod-Vy%C5%A1n%C3%A9_Nemeck%C3%A9.jpg" is not recognized.
  • In consequence this valid image is removed after changing something

Details

SubjectRepoBranchLines +/-
URL decode file names in gallery, as in PHP parsermediawiki/extensions/VisualEditormaster+5 -0
Customize query in gerrit

Event Timeline

Raymond created this task.Sep 13 2017, 10:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2017, 10:42 AM
gerritbot subscribed.Sep 13 2017, 1:04 PM

Change 377748 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] URL decode file names in gallery, as in PHP parser

https://gerrit.wikimedia.org/r/377748

gerritbot added a project: Patch-For-Review.Sep 13 2017, 1:04 PM
• Deskana assigned this task to Esanders.Sep 13 2017, 2:59 PM
• Deskana triaged this task as High priority.
• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a comment.Sep 13 2017, 6:00 PM

Change 377748 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] URL decode file names in gallery, as in PHP parser

https://gerrit.wikimedia.org/r/377748

• Deskana closed this task as Resolved.Sep 13 2017, 6:18 PM
• Deskana set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 13 2017, 6:18 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 13 2017, 6:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL