Page MenuHomePhabricator

Special:BlockIP no longer supports wpBlockReasonList
Closed, ResolvedPublic

Description

Author: wikiadmin

Description:
As of Version 1.12 the parameter wpBlockReasonList does not seem to be actually supported.
This is a useful feature for emergency bot shutoffs where a main reason is preferred to other.

Version 1.11 iterates through the list of reasons and checks against the supplied wpBlockReasonList.

Version 1.12 just uses Xml::listDropDown which doesn't seem to do any selecting at all.


Version: 1.12.x
Severity: minor

Details

Reference
bz15611

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:22 PM
bzimport set Reference to bz15611.
bzimport added a subscriber: Unknown Object (MLST).

Works in 1.13/1.14a, I'll check 1.12

wikiadmin wrote:

Ok, here's the fix, I don't know enough about PHP or SVN enough to do it globally, but it worked fine on mine.

Change SpecialBlockip.php (line 109-111 in version 1.13) from:

		$reasonDropDown = Xml::listDropDown( 'wpBlockReasonList',
			wfMsgForContent( 'ipbreason-dropdown' ),
			wfMsgForContent( 'ipbreasonotherlist' ), '', 'wpBlockDropDown', 4 );

To:

		$reasonDropDown = Xml::listDropDown( 'wpBlockReasonList',
			wfMsgForContent( 'ipbreason-dropdown' ),
			wfMsgForContent( 'ipbreasonotherlist' ), $this->BlockReasonList, 'wpBlockDropDown', 4 );

The select was never specified in the function call.

OK, I see, the problem is just the pre-filling from the url