Page MenuHomePhabricator

Make sure uses of PrivateSettings file in dumps don't rely on symlink
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/#/c/376762/

This is coming; make sure it won't break any of our scripts.

Event Timeline

ArielGlenn created this task.
ArielGlenn moved this task from Short-term backlog to Today on the User-ArielGlenn board.

Base cases are covered:

[ariel@bigtrouble modules]$ grep -r adminsett .
./snapshot/templates/dumps/wikidump.conf.erb:adminsettings=private/PrivateSettings.php
./snapshot/templates/addschanges.conf.erb:adminsettings=private/PrivateSettings.php

One cron script uses this ugly approach, but it works:

db_pass=`echo 'echo $wgDBadminpassword;' | php "$multiversionscript" eval.php aawiki`

All other cron jobs look like they piggyback on MediaWiki directly or on the adminsettings config settings shown above. Not quite done looking though.

I've checked everything in the dumps repos and in puppet that has anything to do with dumps, their related cron jobs, configuration, etc. Even checked a couple unrelated repos like the ops software repo just in case I forgot something. Looks ok.

Yeah I already went through all repos and everything seems to reference it directly. I'm also going to go in two stages: swap the wmf-config to point to the direct file. Wait a bit. Thennnnnn we'll drop the symlink.

ArielGlenn renamed this task from Make sure uses of PrivateSettings file don't rely on symlink to Make sure uses of PrivateSettings file in dumps don't rely on symlink.Sep 18 2017, 9:11 PM
ArielGlenn closed this task as Resolved.

All right, I'm going to close this as done (after making the title of the task a bit less ambiguous).

ArielGlenn moved this task from Backlog to Done on the Dumps-Generation board.