Page MenuHomePhabricator

Increase MFDeviceWidthMobileSmall to 320?
Closed, ResolvedPublic

Description

Currently, MFDeviceWidthMobileSmall is set to 280.
To my knowledge there has been only one Android device with lower than 320px (I think it was a Samsung five or six years ago, not very popular) and since then the minimum width is set equal to the original iPhone with 320px.

In my understanding, the variable should be increased to 320 as well

Event Timeline

Change 381150 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Increase MFDeviceWidthMobileSmall to 320 elsewhere

https://gerrit.wikimedia.org/r/381150

Some context on the name - "MobileSmall" refers to old feature phones e.g. Nokia's that have tiny screens and that's what it's targeted at.
As you point out 320 is a sensible mobile threshold but since MobileFrontend/Minerva skin work in a mobile first way they never care about this. It's the default.

Jdlrobson claimed this task.

Long story short... yes. It's already 320px in Minerva and that's what I'm pushing for in T171365 :)

Change 381150 abandoned by Jdlrobson:
Increase MFDeviceWidthMobileSmall to 320 elsewhere

Reason:
Taken care of https://gerrit.wikimedia.org/r/372551. Then we'll remove these instances.

https://gerrit.wikimedia.org/r/381150