Page MenuHomePhabricator

Descriptive error messages for "Could not open import file"
Closed, ResolvedPublic

Description

Author: mike.lifeguard+bugs

Description:
Currently full history imports are disabled on WMF wikis, but we get the oh-so-generic "Import failed: Could not open import file" error when attempting to do so. Please have Special:Import return a meaningful error message for each kind of error - this one in particular is quite misleading.


Version: unspecified
Severity: normal

Details

Reference
bz15907

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:20 PM
bzimport set Reference to bz15907.
bzimport added a subscriber: Unknown Object (MLST).

mike.lifeguard+bugs wrote:

(In reply to comment #0)

Currently full history imports are disabled on WMF wikis, but we get the
oh-so-generic "Import failed: Could not open import file" error when attempting
to do so. Please have Special:Import return a meaningful error message for each
kind of error - this one in particular is quite misleading.

Apologies; it's not disabled totally, we're just limited to 1000 revisions (when it works). Still, the problem of terrible error messages remains generally.

The wiki doing the import can't possibly know that :), it only knows that it can't get the data from Http::request() that it wanted.

Fwiw: I could do full history imports on my local install as of a few days ago. It doesn't _really_ get the full history, it just thinks it does. The importing wiki doesn't know how many revisions an article has, so it takes all that Special:Export gives it (in this case, 1000 max).

mike.lifeguard+bugs wrote:

(In reply to comment #2)

The wiki doing the import can't possibly know that :), it only knows that it
can't get the data from Http::request() that it wanted.

Fwiw: I could do full history imports on my local install as of a few days ago.
It doesn't _really_ get the full history, it just thinks it does. The importing
wiki doesn't know how many revisions an article has, so it takes all that
Special:Export gives it (in this case, 1000 max).

Then it should check
*how many Export is allowed to give us,
*how many we actually got, and
*how many there actually are

So we can have meaningful messages like:
*"We got 1000/1000 possible revisions, but there are still 442 remaining unimported revisions. [import-the-rest button]"
*"We got 888/888 possible revisions - that's everything!"
*"We got 345/1000 possible revisions because something bad happened. [try-again-but-skip-first-345-revs button]"
*"We got 1/1 possible revisions because that's all we're allowed. Boo-hoo."
*"We got nothing because something bad happened. Foreign wiki should give us 1000 revisions. [ask-again button]"
*"We got nothing because Export on foreign wiki is disabled. Boo-hoo."

  • This bug has been marked as a duplicate of bug 6646 ***