Page MenuHomePhabricator

TestFactoryGeneratorWikibase.test_searchitem_language is failing
Closed, ResolvedPublic

Description

https://travis-ci.org/wikimedia/pywikibot-core/jobs/293984091#L3926

=================================== FAILURES ===================================

____________ TestFactoryGeneratorWikibase.test_searchitem_language _____________

self = <tests.pagegenerators_tests.TestFactoryGeneratorWikibase testMethod=test_searchitem_language>

    def test_searchitem_language(self):

        """Test -searchitem with custom language specified."""

        gf = pagegenerators.GeneratorFactory(site=self.site)

        gf.handleArg('-searchitem:pl:abc')

        gf.handleArg('-limit:1')

        gen = gf.getCombinedGenerator()

        self.assertIsNotNone(gen)

        # ABC disambiguation

        page1 = next(gen)

        self.assertEqual(page1.title(), 'Q286874')

    

        gf = pagegenerators.GeneratorFactory(site=self.site)

        gf.handleArg('-searchitem:en:abc')

        gf.handleArg('-limit:2')

        gen = gf.getCombinedGenerator()

        self.assertIsNotNone(gen)

        # American Broadcasting Company

        page1 = next(gen)

        self.assertEqual(page1.title(), 'Q169889')

        # ABC disambiguation

        page2 = next(gen)

>       self.assertEqual(page2.title(), 'Q286874')

E       AssertionError: u'Q781365' != u'Q286874'

E       - Q781365

E       + Q286874

To reproduce the issue make sure that the cache on WikidataTestCase is turned off.

Event Timeline

Dalba triaged this task as High priority.Oct 28 2017, 11:18 AM
Dalba updated the task description. (Show Details)

Seems like simple change of order in the search results.

Change 387008 had a related patch set uploaded (by Dalba; owner: Dalba):
[pywikibot/core@master] pagegenerators_tests.py: Update the expected search result

https://gerrit.wikimedia.org/r/387008

Change 387008 merged by jenkins-bot:
[pywikibot/core@master] pagegenerators_tests.py: Update the expected search result

https://gerrit.wikimedia.org/r/387008

We had a few successful builds but they have started to fail again.

Dalba removed Dalba as the assignee of this task.Nov 2 2017, 1:19 PM
Dalba removed a project: Patch-For-Review.

Change 388515 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [test] pagegenerators_tests.py: Update the expected search result

https://gerrit.wikimedia.org/r/388515

Change 388515 merged by jenkins-bot:
[pywikibot/core@master] [test] pagegenerators_tests.py: Update the expected search result

https://gerrit.wikimedia.org/r/388515

This comment was removed by Dalba.