Page MenuHomePhabricator

cmcontinue breaks with sortkeys containing pipe characters
Closed, ResolvedPublic


When a sortkey contains a pipe, the API can return a continuation like:

<categorymembers cmcontinue="Bar|Baz|" />

When using that, the API obviously returns the error message:

<error code="cmbadcontinue" info="Invalid continue param. You should pass the original value returned by the previous query">

The same issue may apply to other modules that use non-title-validated strings in continue parameters (if there are any other ones).

Version: 1.14.x
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:20 PM
bzimport set Reference to bz16017.

Created attachment 5448

The attached patch fixes this bug by allowing multiple pipes in cmcontinue; only the last one is treated as a separator.