Page MenuHomePhabricator
Create Task
Maniphest T181712

Navigation popup repositions on open
Open, LowestPublic
Actions

Description

The navigation popup repositions on open for popups which are on the edge of the page, which is a bit janky. Here's a GIF of the experience, click through to see

Untitled.mov.gif (840×996 px, 2 MB)

When the navigation popup is opened, it is positioned to where the user's mouse is in Navpopup.showSoonIfStable and then repositioned when the limitHorizontalPosition function is invoked, which is set on an interval.

A naive suggestion is call limitHorizontalPosition within showSoonIfStable, but I'm not sure that's the best solution.

How can I run my own development version of the script to tinker with the implementation to fix this bug?

Event Timeline

ericandrewlewis created this task.Nov 30 2017, 1:18 PM
Restricted Application added subscribers: Enterprisey, Aklapper. · View Herald TranscriptNov 30 2017, 1:18 PM
ericandrewlewis updated the task description. (Show Details)Nov 30 2017, 1:20 PM
ericandrewlewis updated the task description. (Show Details)
TheDJ triaged this task as Lowest priority.Feb 12 2018, 1:45 PM
TheDJ subscribed.

Popups has some very primitive lazy loading logic and no fixed width. This is a bit outdated honestly.. I've made a small change to call limitHorizontalPosition from showSoonIfStable, though the whole logic here is quite convoluted.. Hopefully this improves it slightly

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL