Page MenuHomePhabricator
Create Task
Maniphest T182304

Cleanup multiple definitions of logstash endpoint in puppet / hiera
Closed, ResolvedPublic
Actions

Description

Multiple puppet modules define their own hiera variable to configure the logstash endpoint. The canonical variable should be logstash_host defined in hieradata/common.yaml.

Details

SubjectRepoBranchLines +/-
service: use the canonical definition of logstash hostoperations/puppetproduction+5 -5
mediawiki: remove unused logging configuration of mediawikioperations/puppetproduction+0 -1
thumbor: use the canonical definition of logstash hostoperations/puppetproduction+44 -34
wdqs: use the canonical definition of logstash hostoperations/puppetproduction+1 -2
gerrit: use the canonical definition of logstash hostoperations/puppetproduction+9 -7
kafkatee: use the canonical definition of logstash hostoperations/puppetproduction+3 -4
aqs: use the canonical definition of logstash hostoperations/puppetproduction+1 -2
elasticsearch: use the canonical definition of logstash hostoperations/puppetproduction+18 -30
Customize query in gerrit

Event Timeline

Gehel created this task.Dec 7 2017, 10:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2017, 10:34 AM
gerritbot subscribed.Dec 7 2017, 10:37 AM

Change 395970 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] elasticsearch: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/395970

gerritbot added a project: Patch-For-Review.Dec 7 2017, 10:37 AM
gerritbot added a comment.Dec 7 2017, 6:03 PM

Change 396072 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] service: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/396072

gerritbot added a comment.Dec 7 2017, 6:28 PM

Change 395970 merged by Gehel:
[operations/puppet@production] elasticsearch: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/395970

debt subscribed.Dec 12 2017, 6:25 PM

This appeared to be fairly easy at first, but turned out to be a big re-factoring amount of work.

debt removed a project: Patch-For-Review.Dec 12 2017, 6:25 PM
gerritbot added a comment.Dec 21 2017, 1:41 PM

Change 399624 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] aqs: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399624

gerritbot added a project: Patch-For-Review.Dec 21 2017, 1:41 PM
Gehel moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.Dec 21 2017, 1:41 PM
gerritbot added a comment.Dec 21 2017, 1:54 PM

Change 399629 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] kafkatee: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399629

gerritbot added a comment.Dec 21 2017, 2:51 PM

Change 399624 merged by Gehel:
[operations/puppet@production] aqs: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399624

gerritbot added a comment.Dec 21 2017, 2:58 PM

Change 399629 merged by Gehel:
[operations/puppet@production] kafkatee: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399629

gerritbot added a comment.Dec 21 2017, 3:12 PM

Change 399644 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] gerrit: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399644

gerritbot added a comment.Dec 21 2017, 3:28 PM

Change 399644 merged by Gehel:
[operations/puppet@production] gerrit: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399644

gerritbot added a comment.Dec 21 2017, 3:39 PM

Change 399650 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] wdqs: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399650

gerritbot added a comment.Dec 21 2017, 4:01 PM

Change 399652 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] thumbor: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399652

gerritbot added a comment.Dec 21 2017, 6:35 PM

Change 399650 merged by Gehel:
[operations/puppet@production] wdqs: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399650

gerritbot added a comment.Jan 3 2018, 9:11 AM

Change 399652 merged by Gehel:
[operations/puppet@production] thumbor: use the canonical definition of logstash host

https://gerrit.wikimedia.org/r/399652

gerritbot added a comment.Jan 18 2018, 1:51 PM

Change 404980 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] mediawiki: remove unused logging configuration of mediawiki

https://gerrit.wikimedia.org/r/404980

gerritbot added a comment.Jan 18 2018, 5:33 PM

Change 404980 merged by Gehel:
[operations/puppet@production] mediawiki: remove unused logging configuration of mediawiki

https://gerrit.wikimedia.org/r/404980

Gehel moved this task from not in use - please delete to Needs Reporting on the Discovery-Search (Current work) board.Jan 18 2018, 5:40 PM

Most references to logstash host are now consolidated in a single variable. There are 2 occurrences left, but they require non trivial refactorings. We can close this task and revisit at some future point.

debt closed this task as Resolved.Feb 2 2018, 5:57 PM
fgiunchedi added a project: observability.Aug 19 2019, 2:27 PM
gerritbot added a comment.Oct 27 2020, 1:47 PM

Change 396072 abandoned by Gehel:
[operations/puppet@production] service: use the canonical definition of logstash host

Reason:

https://gerrit.wikimedia.org/r/396072

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits