Remove constructive flag leftovers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Dec 12 2017, 11:47 PM

Description

There are still code instances of constructive flag in MobileFronted, foremost buttons, that got deprecated a while ago and is going to be removed entirely in upcoming OOUI v0.25.0, see T156874.

Details

	Subject	Repo	Branch	Lines +/-
	Replace instances of constructive and remove option entirely	mediawiki/extensions/MobileFrontend	master	+8 -16
	Replace instances of constructive and remove option entirely	mediawiki/extensions/MobileFrontend	specialpages	+8 -16

Customize query in gerrit

Related Objects

Mentioned Here: T156874: The constructive flag in the OOUI Apex theme should be deprecated in favor of the progressive flag

Event Timeline

Volker_E created this task.Dec 12 2017, 11:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2017, 11:47 PM

Change 398213 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Replace instances of constructive and remove option entirely

https://gerrit.wikimedia.org/r/398213

gerritbot added a project: Patch-For-Review.Dec 14 2017, 6:39 AM

Change 399324 had a related patch set uploaded (by Jdlrobson; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@specialpages] Replace instances of constructive and remove option entirely

https://gerrit.wikimedia.org/r/399324

Change 399324 abandoned by Jdlrobson:
Replace instances of constructive and remove option entirely

https://gerrit.wikimedia.org/r/399324

Change 398213 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace instances of constructive and remove option entirely

https://gerrit.wikimedia.org/r/398213

Volker_E closed this task as Resolved.Dec 20 2017, 3:38 AM

Volker_E claimed this task.

Volker_E triaged this task as High priority.

Volker_E removed a project: Patch-For-Review.

Volker_E removed a subscriber: gerritbot.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 20 2017, 4:00 AM

Volker_E moved this task from Unsorted to OOUI on the UI-Standardization board.Dec 21 2017, 4:56 PM