Page MenuHomePhabricator

Add magic word __NONEWSECTIONLINK__
Closed, ResolvedPublic

Description

Author: mike.lifeguard+bugs

Description:
This would have the opposite effect of NEWSECTIONLINK -- force hiding of the new section link. This is useful for cases where we want to force users to use an inputbox or link with editintro/preload instead of a vanilla new section link.


Version: 1.14.x
Severity: enhancement

Details

Reference
bz16335

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:27 PM
bzimport set Reference to bz16335.
bzimport added a subscriber: Unknown Object (MLST).

jopiswezggzmw wrote:

Proposed patch

Not sure if this is the *best* way to do it but it works.

Turns out setting setNewSection to false doesn't work since the $istalk if statement in SkinTemplate.php overrides it.

Attached:

jopiswezggzmw wrote:

[02:55:34] <aiml> Is there anything wrong with https://bugzilla.wikimedia.org/attachment.cgi?id=5680&action=diff ?
[03:20:43] <TimStarling> aiml: looks fine to me

[03:35:47] <aiml> TimStarling: Cool thanks, any chance of getting it committed? Or what's the usual process on that?
[03:37:12] <Marybelle> aiml: Bugging a committer in here.
[03:37:52] <werdnum> over and over again

^ Tried that and it didn't work so changed to reviewed instead.

jopiswezggzmw wrote:

Any chance of this ever getting committed?

Looks good to me, applied in r47522 for 1.15 dev trunk.