Page MenuHomePhabricator

role::thumbor should compile into a catalogue without dependency cycles
Closed, ResolvedPublic

Description

3) role::thumbor should compile into a catalogue without dependency cycles
   Failure/Error: it { is_expected.to compile }

     error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Failed to parse template thumbor/systemd/thumbor.erb:
       Filepath: /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/thumbor/templates/systemd/thumbor.erb
       Line: 12
       Detail: can't convert nil into Integer
      at /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/systemd/manifests/service.pp:71:20 at /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/thumbor/manifests/service.pp:29 on node wmf-bd808-mbp01.local
   # ./puppet/spec/integration/roles_spec.rb:20:in `block (3 levels) in <top (required)>'

Event Timeline

bd808 created this task.Jan 4 2018, 4:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2018, 4:58 AM

Change 401896 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[mediawiki/vagrant@stretch-migration] thumbor: pass vars to systemd service template

https://gerrit.wikimedia.org/r/401896

bd808 claimed this task.Jan 4 2018, 6:21 AM

Change 401896 merged by jenkins-bot:
[mediawiki/vagrant@stretch-migration] thumbor: pass vars to systemd service template

https://gerrit.wikimedia.org/r/401896

bd808 closed this task as Resolved.Jan 4 2018, 6:19 PM