Page MenuHomePhabricator
Create Task
Maniphest T184378

«Share data about this installation» rechecked on form validation error
Open, Needs TriagePublic
Actions

Description

On the "Name" step of MediaWiki installer, there are a couple of checkboxes:

  • Subscribe to the release announcements mailing list.
  • Share data about this installation with MediaWiki developers.

The first one remembers its state, but the second does not. If you uncheck it, and submit the form with some value which fails (no site name, insecure password, etc.), «Share data about this installation with MediaWiki developers.» goes back to its default (checked) state.

Expected: it should keep the previous state.

Details

SubjectRepoBranchLines +/-
Fix web installer pingback checkbox bugmediawiki/coremaster+1 -2
Customize query in gerrit

Event Timeline

Platonides created this task.Jan 7 2018, 5:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2018, 5:49 PM
• 238482n375 set Security to Software security bug.Jun 15 2018, 8:05 AM
• 238482n375 added a project: acl*security.
• 238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
• 238482n375 subscribed.
This comment was removed by Aklapper.
Aklapper removed a project: acl*security.Jun 15 2018, 1:30 PM
Aklapper changed the visibility from "Custom Policy" to "Public (No Login Required)".
Aklapper removed a subscriber: • 238482n375.
Novem_Linguae subscribed.EditedJul 7 2022, 6:20 AM

Bug still present as of 1.38.0-alpha. Subscribing, maybe I'll write a patch for this one.

Is also checked when hitting back from the next screen, even if you previously unchecked it.

@Aklapper, there's a spammy post above this one that can probably be deleted.

2022-07-06_231530.png (643×1 px, 59 KB)

gerritbot added a comment.Jul 9 2022, 2:48 AM

Change 812428 had a related patch set uploaded (by Gerrit Patch Uploader; author: Novem Linguae):

[mediawiki/core@master] Fix web installer pingback checkbox bug

https://gerrit.wikimedia.org/r/812428

gerritbot added a project: Patch-For-Review.Jul 9 2022, 2:48 AM
Novem_Linguae added a comment.Jul 23 2022, 8:44 AM

Additional bug on the same form: It will forget your custom wiki name. It always resets back to "MyWiki".

image.png (290×587 px, 12 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL