Page MenuHomePhabricator
Create Task
Maniphest T18498

Fatal Error while editing from old revision
Closed, ResolvedPublic
Actions

Description

Author: charlie

Description:
Users have reported getting Fatal Errors while editing an old revision of a page (an example has been set as the URL of this bug):

Fatal error: Call to protected method Article::setOldSubtitle() from context 'EditPage' in /home/yourwiki/htdocs/html/w/includes/EditPage.php on line 1182

This should be a simple fix, but I don't want to break anything, so what are your thoughts on it?

Version: 1.14.x
Severity: major
URL: http://meta.yourwiki.net/w/index.php?title=Requests_for_new_wikis&action=edit&oldid=2596

Details

Reference
bz16498

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:24 PM
• bzimport added a project: MediaWiki-Page-diffs.
• bzimport set Reference to bz16498.
• bzimport created this task.Nov 29 2008, 10:11 PM
• bzimport added a comment.Nov 29 2008, 10:11 PM

charlie wrote:

Changed severity to major, woops.

Platonides added a comment.Nov 29 2008, 10:17 PM

Broken on r44015.
Just remove the protected word on line 2855 of Article.php until it is fixed.

As http://www.mediawiki.org/wiki/Coding_Conventions says
"Newer code will use proper visibilities, but do not add it to existing code without first checking, testing and refactoring as required, because the above rule has been broken in several places"

IAlex added a comment.Nov 29 2008, 10:18 PM

fixed in r44051.

Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL