Unexpected ResourceWarning in namespace_tests.TestNamespaceDictDeprecated
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dalba
	Jan 16 2018, 2:13 PM

Description

https://travis-ci.org/wikimedia/pywikibot/jobs/329427210#L4794

======================================================================
FAIL: test_lookup_name (tests.namespace_tests.TestNamespaceDictDeprecated)
Test Namespace.lookup_name.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/wikimedia/pywikibot/tests/namespace_tests.py", line 319, in test_lookup_name
    self.assertIsInstance(file_ns, Namespace)
  File "/home/travis/build/wikimedia/pywikibot/tests/aspects.py", line 1193, in inner_assert
    self.after_assert(assertion, *args, **kwargs)
  File "/home/travis/build/wikimedia/pywikibot/tests/aspects.py", line 1735, in after_assert
    self.assertOneDeprecation()
  File "/home/travis/build/wikimedia/pywikibot/tests/aspects.py", line 1674, in assertOneDeprecation
    self.assertDeprecation(msg)
  File "/home/travis/build/wikimedia/pywikibot/tests/aspects.py", line 1661, in assertDeprecation
    self.assertDeprecationFile(self.expect_warning_filename)
  File "/home/travis/build/wikimedia/pywikibot/tests/aspects.py", line 1704, in assertDeprecationFile
    % (filename, item))
AssertionError: expected warning filename /home/travis/build/wikimedia/pywikibot/tests/namespace_tests.py; warning item: {message : ResourceWarning("unclosed <socket.socket fd=20, family=AddressFamily.AF_INET, type=2049, proto=6, laddr=('172.17.0.11', 43256), raddr=('195.28.75.37', 443)>",), category : 'ResourceWarning', filename : '/opt/python/3.6.3/lib/python3.6/inspect.py', lineno : 684, line : None}
----------------------------------------------------------------------

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Ignore unclosed socket warnings for py3	pywikibot/core	master	+3 -2

Customize query in gerrit

Revisions and Commits

rPWBC pywikibot
	rPWBCc50bcee3bcb1 [bugfix] Ignore unclosed socket warnings

Related Objects

Mentioned In: T185188: Unexpected ResourceWarning in TestDeprecatedDataSiteMethods.test_get_sitelinks

Event Timeline

Dalba created this task.Jan 16 2018, 2:13 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 16 2018, 2:13 PM

Dalba updated the task description. (Show Details)Jan 16 2018, 2:16 PM

Xqt claimed this task.Jan 16 2018, 2:25 PM

We also recently had another ResourceWarning in cookiejar.py:

https://travis-ci.org/wikimedia/pywikibot/jobs/329129077#L4352

________________ TestDeprecatedDataSiteMethods.test_get_aliases ________________
self = <tests.wikibase_tests.TestDeprecatedDataSiteMethods testMethod=test_get_aliases>
    def test_get_aliases(self):
        """Test get_aliases."""
        data = self.repo.get_aliases(60)
>       self.assertOneDeprecation()
tests/wikibase_tests.py:1996: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/aspects.py:1674: in assertOneDeprecation
    self.assertDeprecation(msg)
tests/aspects.py:1661: in assertDeprecation
    self.assertDeprecationFile(self.expect_warning_filename)
tests/aspects.py:1704: in assertDeprecationFile
    % (filename, item))
E   AssertionError: expected warning filename /home/travis/build/wikimedia/pywikibot/tests/wikibase_tests.py; warning item: {message : ResourceWarning('unclosed <socket.socket object, fd=17, family=2, type=2049, proto=6>',), category : 'ResourceWarning', filename : '/opt/python/3.3.6/lib/python3.3/http/cookiejar.py', lineno : 1191, line : None}

Dalba triaged this task as High priority.Jan 16 2018, 2:26 PM

Dalba added a commit: rPWBCc50bcee3bcb1: [bugfix] Ignore unclosed socket warnings.Jan 16 2018, 2:32 PM

Change 404449 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Ignore unclosed socket warnings for py3

https://gerrit.wikimedia.org/r/404449

gerritbot added a project: Patch-For-Review.Jan 16 2018, 2:40 PM

Dalba closed this task as Resolved.Jan 16 2018, 2:49 PM

Change 404449 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Ignore unclosed socket warnings for py3