DiffWithinRangeChecker throws TypeError when checking quantity against range with unit “year”
Closed, ResolvedPublic
Actions

Description

If you define a “difference within range” constraint with quantities using the “year” unit on a quantity-type property, attempting to check the property will throw a TypeError because the DiffWithinRangeChecker gets confused and tries to check the constraint like on a time-type property.

Details

	Subject	Repo	Branch	Lines +/-
	Only compute difference in years on time values	mediawiki/extensions/WikibaseQualityConstraints	master	+26 -1

Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 1 2018, 3:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2018, 3:27 PM

Change 407449 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Only compute difference in years on time values

https://gerrit.wikimedia.org/r/407449

gerritbot added a project: Patch-For-Review.Feb 1 2018, 3:44 PM

Change 407449 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Only compute difference in years on time values

https://gerrit.wikimedia.org/r/407449

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 1 2018, 4:16 PM

Lucas_Werkmeister_WMDE claimed this task.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 1 2018, 5:01 PM

DiffWithinRangeChecker throws TypeError when checking quantity against range with unit “year”Closed, ResolvedPublicActions

Description

Details

Event Timeline

DiffWithinRangeChecker throws TypeError when checking quantity against range with unit “year”
Closed, ResolvedPublic
Actions