Page MenuHomePhabricator

DiffWithinRangeChecker throws TypeError when checking quantity against range with unit “year”
Closed, ResolvedPublic

Description

If you define a “difference within range” constraint with quantities using the “year” unit on a quantity-type property, attempting to check the property will throw a TypeError because the DiffWithinRangeChecker gets confused and tries to check the constraint like on a time-type property.

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseQualityConstraints : masterOnly compute difference in years on time values

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2018, 3:27 PM

Change 407449 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Only compute difference in years on time values

https://gerrit.wikimedia.org/r/407449

Change 407449 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Only compute difference in years on time values

https://gerrit.wikimedia.org/r/407449

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 1 2018, 4:16 PM
Lucas_Werkmeister_WMDE claimed this task.