Page MenuHomePhabricator

ext.thanks.revthank depends on jquery.cookie
Closed, ResolvedPublic0.5 Estimate Story Points

Description

Exception in module-execute in module ext.thanks.revthank:
TypeError: $.cookie is not a function

I guess it's undeclared as a dependency because the extension is normally used with other things that have that dependency already.

Details

Related Gerrit Patches:
mediawiki/extensions/Thanks : masterAdd jquery.cookie dependency

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 21 2018, 2:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson updated the task description. (Show Details)Feb 21 2018, 2:11 AM

Change 413088 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Thanks@master] Add jquery.cookie dependency

https://gerrit.wikimedia.org/r/413088

Samwilson set the point value for this task to 0.5.
Samwilson moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.

Change 413088 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Add jquery.cookie dependency

https://gerrit.wikimedia.org/r/413088

Samwilson closed this task as Resolved.Feb 27 2018, 2:36 AM
Samwilson moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.