Maniphest T187851

ext.thanks.revthank depends on jquery.cookie
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Assigned To

Authored By

	Samwilson
	Feb 21 2018, 2:10 AM

Tags

Referenced Files

None

Subscribers

Description

Exception in module-execute in module ext.thanks.revthank:
TypeError: $.cookie is not a function

I guess it's undeclared as a dependency because the extension is normally used with other things that have that dependency already.

Details

	Subject	Repo	Branch	Lines +/-
	Add jquery.cookie dependency	mediawiki/extensions/Thanks	master	+1 -0

Customize query in gerrit

Event Timeline

Samwilson created this task.Feb 21 2018, 2:10 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 21 2018, 2:10 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Samwilson updated the task description. (Show Details)Feb 21 2018, 2:11 AM

Change 413088 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Thanks@master] Add jquery.cookie dependency

https://gerrit.wikimedia.org/r/413088

gerritbot added a project: Patch-For-Review.Feb 21 2018, 3:50 AM

Samwilson claimed this task.Feb 21 2018, 4:55 AM

Samwilson added a project: Community-Tech-Sprint.

Samwilson set the point value for this task to 0.5.

Samwilson moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.

Change 413088 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Add jquery.cookie dependency

https://gerrit.wikimedia.org/r/413088

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 24 2018, 1:01 AM

Samwilson closed this task as Resolved.Feb 27 2018, 2:36 AM

Samwilson moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.

• TBolliger edited projects, added Community-Tech; removed Community-Tech-Sprint.Feb 28 2018, 1:40 AM

• TBolliger moved this task from New & TBD Tickets to Archive on the Community-Tech board.Feb 28 2018, 1:45 AM