Page MenuHomePhabricator

Special:Newpages/Special:Recentchanges should be localized on the "mark changes as patrolled" confirmation
Closed, ResolvedPublic

Description

Patch to includes/Article.php to add wfMsg() where necessary

  1. Enable patrolling
  2. Edit as non-autopatrol user
  3. Switch to the patrolling user
  4. Switch user interface to non-English
  5. Mark the change as patrolled
  6. The confirmation message:

"Return to Special:Recentchanges" says

"Powrót do Specjalna:Recentchanges" in Polish.

This means, that Title::MakeTitle provides localized namespace name, but no the page name.

The fix is trivial I guess, see the patch attached.


Version: 1.15.x
Severity: trivial

attachment patch-sidebar-boxes-2557 ignored as obsolete

Details

Reference
bz17103

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:30 PM
bzimport set Reference to bz17103.
bzimport added a subscriber: Unknown Object (MLST).

Patch does not seem correspond to the bug description. Maybe wrong patch?

Created attachment 5758
Patch to includes/Article.php to add wfMsg() where necessary (really this time)

Oh, yes, the attachment fixes bug 2557, not this one.

Updated - sorry for my mistake.

Attached:

Thanks, fixed in r46659. I had to use a method of SpecialPage though.

Created attachment 5819
Capitalize special page names

Well, one needs to capitalize special page names to work this way.

Attached:

Tested in r47298, still does not work, please see the second patch.

Tested, works as of r47611. Thank you very much!