Page MenuHomePhabricator

Deprecation of pagegenerators.RepeatingGenerator
Closed, ResolvedPublic

Description

pagegenerators.RepeatingGenerator is not a suitable re-implementation of the compat's "repeat" parameters.

In compat the generator runs through all items and repeat that generator again and again with new changes first but it also yielded old items which won't to have again.

The new implementation retrieves the lastmost entry, waits for a time and continues with re-reading starting at the last item found. That is what eventstreams do and it is more suitable to use eventstreams instead.

Therefore I propose to deprecate RepeatingGenerator which btw. isn't used anywhere in the current framework..

Event Timeline

Xqt triaged this task as Low priority.Apr 15 2018, 2:14 PM

Change 426755 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [deprecation] Deprecate pagegenerators.RepeatingGenerator

https://gerrit.wikimedia.org/r/426755

Change 426755 merged by jenkins-bot:
[pywikibot/core@master] [deprecation] Deprecate pagegenerators.RepeatingGenerator

https://gerrit.wikimedia.org/r/426755