Page MenuHomePhabricator

Add placeholder text to Review filters
Closed, ResolvedPublic

Description

Task

In the Review interface, we have filters for both Username and Partner. They currently show up entirely blank, but previously had some placeholder text there.

We should add 'Username' and 'Partner' placeholder text to the boxes.

Good first bug

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Related Objects

Event Timeline

Agree with restoring labels, but the filtering is a dropdown/search combo; you can type or scroll.

Samwalton9 moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.

...Yeeess. My issue is not that you actually have to scroll to the user you're interested in, I get that you can just type it. But in this particular case I don't think you'd ever really want to scroll, so should just have typing.

Samwalton9 renamed this task from Labels on filters to Add labels to Review filters.Jul 13 2018, 1:33 PM
Samwalton9 renamed this task from Add labels to Review filters to Add placeholder text to Review filters.
Swayamsrk added a subscriber: Swayamsrk.

Can I work on this?

Absolutely! Let me know if you need any help.

I was having a problem in running the 2nd step of building which is "Run migrations docker-compose exec twlight /app/bin/virtualenv_migrate.sh" .I am getting this error

Screenshot from 2020-02-05 01-54-22.png (768×1 px, 87 KB)
.I have tried everything can you help me?

@Swayamsrk Did you install Docker and Docker Compose? It looks like Docker may not be running.

If it's running and installed you might need to just run the command as sudo.

Yes, I have already installed Docker and Docker Compose.

Screenshot from 2020-02-05 20-46-03.png (768×1 px, 98 KB)

This is the error with sudo.
I have apache2 running on my localhost is that a problem?

Alright, looks like sudo helped. Can you show me the output for sudo docker ps?

@Swayamsrk Were you able to run the project on your localhost by following the step1: docker-compose build && docker-compose up?

No, actually I have apache2 installed which opens up when I try to open localhost.

Can you attach the output of docker-compose build && docker-compose up?

Screenshot from 2020-02-07 00-08-53.png (768×1 px, 215 KB)

I don't why this error is coming but it was not coming when I have done it earlier.

wget: can't connect to remote host (52.216.102.139): Operation timed out looks like your container couldn't connect to the internet. Make sure you have a working internet connection and enable connections through your firewall.

Samwalton9 moved this task from Doing to Done on the Library-Card-Platform board.