Page MenuHomePhabricator
Create Task
Maniphest T195162

SendGrid extension is missing @covers tags
Closed, ResolvedPublic
Actions

Description

PHPCS has identified that some of the SendGrid PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

SubjectRepoBranchLines +/-
Add @covers tags to SendGrid's PHPUnit testsmediawiki/extensions/SendGridmaster+3 -0
Add @covers tags to SendGrid's PHPUnit testsmediawiki/extensions/SendGridmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Legoktm added projects: MediaWiki-extensions-SendGrid, Test-Coverage.May 20 2018, 1:53 AM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM
xSavitar awarded a token.May 20 2018, 5:39 PM
xSavitar subscribed.
gerritbot subscribed.May 30 2018, 11:27 AM

Change 436272 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/SendGrid@master] Add @covers tags to SendGrid's PHPUnit tests

https://gerrit.wikimedia.org/r/436272

gerritbot added a project: Patch-For-Review.May 30 2018, 11:27 AM
xSavitar claimed this task.May 30 2018, 11:28 AM
xSavitar triaged this task as Medium priority.
xSavitar mentioned this in rESNG74bc37009b75: Add @covers tags to SendGrid's PHPUnit tests.May 30 2018, 11:29 AM
xSavitar mentioned this in rESNG067f58a240e8: Add @covers tags to SendGrid's PHPUnit tests.May 30 2018, 11:33 AM
xSavitar mentioned this in rESNGcee9d5a48db5: Add @covers tags to SendGrid's PHPUnit tests.
• Vvjjkkii renamed this task from SendGrid extension is missing @covers tags to 5lcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii removed xSavitar as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 5lcaaaaaaa to SendGrid extension is missing @covers tags.Jul 1 2018, 8:54 PM
CommunityTechBot assigned this task to xSavitar.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
gerritbot added a comment.Jul 5 2018, 5:03 PM

Change 436272 abandoned by D3r1ck01:
Add @covers tags to SendGrid's PHPUnit tests

Reason:
Need to upgrade sendgrid's package. Will do a different patch with all the refactoring done!

https://gerrit.wikimedia.org/r/436272

xSavitar moved this task from Backlog to Doing (On-Going) on the MediaWiki-extensions-SendGrid board.Jul 6 2018, 9:32 AM
gerritbot added a comment.Jul 6 2018, 9:39 AM

Change 444178 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/SendGrid@master] Add @covers tags to SendGrid's PHPUnit tests

https://gerrit.wikimedia.org/r/444178

xSavitar mentioned this in rESNG238dafe2ef4d: Add @covers tags to SendGrid's PHPUnit tests.Jul 6 2018, 9:40 AM
xSavitar mentioned this in rESNGfce730117ffa: Add @covers tags to SendGrid's PHPUnit tests.Jul 6 2018, 9:52 AM
xSavitar mentioned this in rESNGe28776f1ddc9: Add @covers tags to SendGrid's PHPUnit tests.Jul 9 2018, 5:36 PM
xSavitar mentioned this in rESNG849ce22b1838: Add @covers tags to SendGrid's PHPUnit tests.Jul 9 2018, 6:05 PM
gerritbot added a comment.Jul 19 2018, 2:26 PM

Change 444178 merged by jenkins-bot:
[mediawiki/extensions/SendGrid@master] Add @covers tags to SendGrid's PHPUnit tests

https://gerrit.wikimedia.org/r/444178

xSavitar closed this task as Resolved.Jul 19 2018, 2:28 PM

Thanks @Legoktm for filing this. It's been resolved and thanks for merging :)

xSavitar moved this task from Doing (On-Going) to Completed (Done) on the MediaWiki-extensions-SendGrid board.Jul 19 2018, 2:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL