SocialProfile's Special:GiftManagerLogo and Special:SystemGiftManagerLogo as well as SportsTeams' (which doesn't have its own Phab component since it's a rather site-specific extension that has been for years and remains a work-in-progress) Special:SportsManagerLogo and Special:SportsTeamsManagerLogo special pages reference the global function wfImageArchiveDir, which, according to some googling, existed in MediaWiki core's ImageFunctions.php...back in the MediaWiki 1.5 (!) era, which is when the social tools were originally written.
Questions:
- What's the present-day replacement for wfImageArchiveDir?
- Can the code in practise even hit the case where that function would be called? wfImageArchiveDir is called by these special pages' saveTempUploadedFile method, which in turn is called by their stashSession, which does look like it could be called from somewhere...but I don't understand the concept of "stashed uploads" well enough, but I think that social tools don't really support that?
In any case the uploading special pages in Social-Tools are horrible and could use quite a bit of TLC...