Page MenuHomePhabricator
Create Task
Maniphest T198216

[PCRGUIInserts] Invalid return from PCRGUIInserts::BeforePageDisplay for unabortable BeforePageDisplay.
Closed, ResolvedPublic
Actions

Description

index.php?uselang=en&title=Special%3ABlankPage
UnexpectedValueException from line 236 of /workspace/src/includes/Hooks.php:
    Invalid return from PCRGUIInserts::BeforePageDisplay for unabortable BeforePageDisplay.

#0 /workspace/src/includes/OutputPage.php(2447): Hooks::runWithoutAbort(string, array)
#1 /workspace/src/includes/MediaWiki.php(874): OutputPage->output(boolean)
#2 /workspace/src/includes/MediaWiki.php(886): MediaWiki->{closure}()
#3 /workspace/src/includes/MediaWiki.php(524): MediaWiki->main()
#4 /workspace/src/index.php(42): MediaWiki->run()

Repro: comment check experimental on dummy change https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PCRGUIInserts/+/324111/

Details

SubjectRepoBranchLines +/-
Do not return output in BeforePageDisplay hookmediawiki/extensions/PCRGUIInsertsmaster+1 -1
Do not return output in BeforePageDisplay hookmediawiki/extensions/PCRGUIInsertsREL1_31+1 -1
Do not return output in BeforePageDisplay hookmediawiki/extensions/PCRGUIInsertsREL1_30+1 -1
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Jun 26 2018, 1:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2018, 1:52 PM
hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 26 2018, 1:52 PM
hashar updated the task description. (Show Details)
hashar added a comment.Jun 26 2018, 1:58 PM

That comes from REL1_31 patch c7d9e79f9e9300dfbf078d34010c5bd0ddd08a81 / T173615 which made several hooks unabortable.

gerritbot subscribed.Jun 26 2018, 2:09 PM

Change 442109 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/PCRGUIInserts@master] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442109

gerritbot added a project: Patch-For-Review.Jun 26 2018, 2:09 PM
gerritbot added a comment.Jun 26 2018, 2:37 PM

Change 442112 had a related patch set uploaded (by Krinkle; owner: Hashar):
[mediawiki/extensions/PCRGUIInserts@REL1_31] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442112

gerritbot added a comment.Jun 26 2018, 2:37 PM

Change 442113 had a related patch set uploaded (by Krinkle; owner: Hashar):
[mediawiki/extensions/PCRGUIInserts@REL1_30] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442113

gerritbot added a comment.Jun 26 2018, 2:38 PM

Change 442114 had a related patch set uploaded (by Krinkle; owner: Hashar):
[mediawiki/extensions/PCRGUIInserts@REL1_27] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442114

gerritbot added a comment.Jun 26 2018, 2:42 PM

Change 442109 merged by jenkins-bot:
[mediawiki/extensions/PCRGUIInserts@master] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442109

gerritbot added a comment.Jun 26 2018, 2:45 PM

Change 442113 merged by jenkins-bot:
[mediawiki/extensions/PCRGUIInserts@REL1_30] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442113

gerritbot added a comment.Jun 26 2018, 2:46 PM

Change 442112 merged by jenkins-bot:
[mediawiki/extensions/PCRGUIInserts@REL1_31] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442112

hashar closed this task as Resolved.Jun 26 2018, 3:27 PM
hashar claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits