Page MenuHomePhabricator

[PCRGUIInserts] Invalid return from PCRGUIInserts::BeforePageDisplay for unabortable BeforePageDisplay.
Closed, ResolvedPublic

Description

index.php?uselang=en&title=Special%3ABlankPage
UnexpectedValueException from line 236 of /workspace/src/includes/Hooks.php:
    Invalid return from PCRGUIInserts::BeforePageDisplay for unabortable BeforePageDisplay.

#0 /workspace/src/includes/OutputPage.php(2447): Hooks::runWithoutAbort(string, array)
#1 /workspace/src/includes/MediaWiki.php(874): OutputPage->output(boolean)
#2 /workspace/src/includes/MediaWiki.php(886): MediaWiki->{closure}()
#3 /workspace/src/includes/MediaWiki.php(524): MediaWiki->main()
#4 /workspace/src/index.php(42): MediaWiki->run()

Repro: comment check experimental on dummy change https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PCRGUIInserts/+/324111/

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2018, 1:52 PM

That comes from REL1_31 patch c7d9e79f9e9300dfbf078d34010c5bd0ddd08a81 / T173615 which made several hooks unabortable.

Change 442109 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/PCRGUIInserts@master] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442109

Change 442112 had a related patch set uploaded (by Krinkle; owner: Hashar):
[mediawiki/extensions/PCRGUIInserts@REL1_31] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442112

Change 442113 had a related patch set uploaded (by Krinkle; owner: Hashar):
[mediawiki/extensions/PCRGUIInserts@REL1_30] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442113

Change 442114 had a related patch set uploaded (by Krinkle; owner: Hashar):
[mediawiki/extensions/PCRGUIInserts@REL1_27] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442114

Change 442109 merged by jenkins-bot:
[mediawiki/extensions/PCRGUIInserts@master] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442109

Change 442113 merged by jenkins-bot:
[mediawiki/extensions/PCRGUIInserts@REL1_30] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442113

Change 442112 merged by jenkins-bot:
[mediawiki/extensions/PCRGUIInserts@REL1_31] Do not return output in BeforePageDisplay hook

https://gerrit.wikimedia.org/r/442112

hashar closed this task as Resolved.Jun 26 2018, 3:27 PM
hashar claimed this task.