Page MenuHomePhabricator

Sample code dialog has extraneous margin
Closed, ResolvedPublic

Description

Looks like the dialog is providing its own padding, but that doesn't play well with the child nodes (H2 and PRE) already having their own margins.

Normally solved by using margin instead of padding so that they auto-collapse, but in this case the dialog is a single element, so there is no where for the margin to be applied to (if applied to the dialog directly, it would apply to the transparent space outside the dialog, not the area inside the background/border box).

Event Timeline

Krinkle created this task.Jun 26 2018, 10:42 PM
Restricted Application added a project: Analytics. · View Herald TranscriptJun 26 2018, 10:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 442213 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/EventLogging@master] Fix extraneous margin inside the code-samples dialog

https://gerrit.wikimedia.org/r/442213

Change 442213 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Fix extraneous margin inside the code-samples dialog

https://gerrit.wikimedia.org/r/442213

Krinkle closed this task as Resolved.Jun 27 2018, 10:44 PM
Krinkle removed a project: Patch-For-Review.