Page MenuHomePhabricator
Create Task
Maniphest T201360

BadMethodCallException when trying to view search results with offset>10000
Closed, ResolvedPublic
Actions

Description

https://www.wikidata.org/w/index.php?title=Special:Search&limit=20&offset=10000&profile=default&search=test

Compare: https://en.wikipedia.org/w/index.php?title=Special:Search&limit=20&offset=10000&profile=default&search=test

(both have much more than 10000 results)

Details

SubjectRepoBranchLines +/-
Add warning when requesting results beyond the supported limitmediawiki/extensions/CirrusSearchmaster+5 -2
Search: transform and createEmpty must return same typemediawiki/extensions/Wikibasemaster+5 -1
Customize query in gerrit

Event Timeline

Bugreporter created this task.Aug 6 2018, 8:54 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptAug 6 2018, 8:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
debt triaged this task as Medium priority.Aug 9 2018, 5:09 PM
debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.
debt subscribed.

This is a known exception — for returning no more than 10,000 results. However, there should be a nicer response; we'll take a look.

gerritbot subscribed.Aug 17 2018, 9:43 PM

Change 453533 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Add warning when requesting results beyond the supported limit

https://gerrit.wikimedia.org/r/453533

gerritbot added a project: Patch-For-Review.Aug 17 2018, 9:43 PM
gerritbot added a comment.Aug 17 2018, 10:11 PM

Change 453537 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/Wikibase@master] Search: transform and createEmpty must return same type

https://gerrit.wikimedia.org/r/453537

EBernhardson claimed this task.Aug 17 2018, 10:12 PM
EBernhardson moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.
gerritbot added a comment.Aug 20 2018, 12:49 PM

Change 453533 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add warning when requesting results beyond the supported limit

https://gerrit.wikimedia.org/r/453533

gerritbot added a comment.Aug 20 2018, 12:59 PM

Change 453537 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Search: transform and createEmpty must return same type

https://gerrit.wikimedia.org/r/453537

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 20 2018, 1:00 PM
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Aug 20 2018, 4:16 PM
debt closed this task as Resolved.Aug 24 2018, 4:05 PM

Using this sample query, the new warning has been updated to: A warning has occured while searching: Could not retrieve results. Up to 10000 search results are supported, but results starting at 10000 were requested.

Thanks, Erik!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL