Page MenuHomePhabricator
Create Task
Maniphest T202577

"Home" link of AWMD stats tool (sometimes) uses HTTP [Not Secure] protocol instead of HTTPS
Closed, ResolvedPublic
Actions

Assigned To
Nathan_fraignt
Authored By
xSavitar
Aug 22 2018, 7:57 PM
Tags
Referenced Files
F26113707: Screen Shot 2018-09-20 at 21.27.17.png
Sep 20 2018, 8:31 PM
F25240090: Screen Shot 2018-08-22 at 20.54.13.png
Aug 22 2018, 7:57 PM
F25240074: Screen Shot 2018-08-22 at 20.53.56.png
Aug 22 2018, 7:57 PM
Subscribers
Aklapper
gerritbot
xSavitar
Zppix

Description

This task is about a tool at https://tools.wmflabs.org/awmd-stats/ running on Toolforge:

Clicking on the "Home" link

Screen Shot 2018-08-22 at 20.53.56.png (62×113 px, 7 KB)
of the AWMD stats tool sometimes sends an HTTP request to Toolforge instead of an HTTPS. This should be fixed, it's just a tweak on the base template sending the request so it always uses the HTTPS protocol.

Expected

Screen Shot 2018-08-22 at 20.54.13.png (38×402 px, 13 KB)

Actual (sometimes)

Screen Shot 2018-09-20 at 21.27.17.png (55×478 px, 14 KB)

Developer Notes

Work should be done on the base template and running the tool on deployment can be found on the README.md file.

Details

SubjectRepoBranchLines +/-
Fix 'Home' link not using HTTPS protocollabs/tools/awmd-statsmaster+12 -12
Fix linking "Home" to HTTPSlabs/tools/awmd-statsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

xSavitar created this task.Aug 22 2018, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2018, 7:57 PM
xSavitar renamed this task from "Home" link of AWMD stats tool links to HTTP version of site instead of HTTPS to "Home" link of AWMD stats tool (sometimes) uses HTTP [Not Secure] protocol instead of HTTPS.Aug 22 2018, 7:59 PM
sguebo_WMF added a project: good first task.Aug 22 2018, 9:13 PM
Zppix added a project: Google-Code-in-2018.Sep 18 2018, 1:06 PM
Zppix subscribed.

I will mentor this.

xSavitar updated the task description. (Show Details)Sep 20 2018, 8:31 PM
xSavitar moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.Sep 20 2018, 8:36 PM
xSavitar added a comment.EditedSep 20 2018, 8:50 PM

Imported as: https://codein.withgoogle.com/tasks/4988866348974080/.

Aklapper updated the task description. (Show Details)Oct 3 2018, 12:39 PM
Aklapper updated the task description. (Show Details)
xSavitar moved this task from awmd-stats-tool (New Tasks) to New Contributor's Tasks (Incoming) on the Africa-Wikimedia-Developers board.Oct 6 2018, 7:12 PM
Liuxinyu970226 subscribed.Oct 21 2018, 2:45 AM
Kizule claimed this task.Oct 26 2018, 2:13 PM
Kizule subscribed.

I think to I can fix this. I claimed task on Google-Code-in-2018.

Restricted Application added a project: User-Kizule. · View Herald TranscriptOct 26 2018, 2:13 PM
gerritbot subscribed.Oct 26 2018, 3:15 PM

Change 469893 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[labs/tools/awmd-stats@master] Fix linking "Home" to HTTPS

https://gerrit.wikimedia.org/r/469893

gerritbot added a project: Patch-For-Review.Oct 26 2018, 3:15 PM
Kizule mentioned this in rLTAS28f34caafc6d: Fix linking "Home" to HTTPS.Oct 26 2018, 3:26 PM
Kizule mentioned this in rLTAS5d8a3927301c: Fix linking "Home" to HTTPS.
gerritbot added a comment.Oct 26 2018, 9:34 PM

Change 469893 abandoned by Zoranzoki21:
Fix linking "Home" to HTTPS

https://gerrit.wikimedia.org/r/469893

Kizule removed Kizule as the assignee of this task.Oct 26 2018, 9:35 PM
Kizule removed projects: Patch-For-Review, User-Kizule.
Kizule unsubscribed.
gerritbot added a comment.Oct 28 2018, 6:51 PM

Change 470250 had a related patch set uploaded (by Nathan fraignt; owner: Nathan fraignt):
[labs/tools/awmd-stats@master] Fix home link not using https

https://gerrit.wikimedia.org/r/470250

gerritbot added a project: Patch-For-Review.Oct 28 2018, 6:51 PM
Nathan_fraignt mentioned this in rLTAS0275fd6b6ebf: Fix home link not using https.Oct 28 2018, 6:52 PM
Nathan_fraignt mentioned this in rLTAS06325213b6de: Fix home link not using https.Oct 28 2018, 7:31 PM
Nathan_fraignt mentioned this in rLTAS150787858fae: Fix home link not using https.Oct 28 2018, 7:38 PM
Nathan_fraignt mentioned this in rLTAS62f9c0ef926b: Fix home link not using https.
Nathan_fraignt mentioned this in rLTAS1fa89df49605: Fix home link not using https.Oct 28 2018, 7:49 PM
xSavitar mentioned this in rLTAScb168792a8c4: Fix home link not using https.Oct 28 2018, 8:14 PM
xSavitar mentioned this in rLTAS7219589fd716: Fix home link not using https.Oct 28 2018, 8:18 PM
xSavitar mentioned this in rLTAS0ae3b19442f4: Fix home link not using https.Oct 28 2018, 8:23 PM
xSavitar mentioned this in rLTAS4bf499c8d769: Fix home link not using https.Oct 28 2018, 8:25 PM
Nathan_fraignt mentioned this in rLTAS4ca067b8dae6: Fix home link not using https.Oct 28 2018, 9:01 PM
Nathan_fraignt mentioned this in rLTAS4014fd74dc3b: Fix home link not using https.Oct 30 2018, 11:35 AM
Nathan_fraignt mentioned this in rLTAS80de02c1b3d3: Fix home link not using https.Oct 30 2018, 11:41 AM
Nathan_fraignt mentioned this in rLTAS3b4c4f79b70d: Fix home link not using https.Oct 30 2018, 11:49 AM
Nathan_fraignt mentioned this in rLTAS4bea67e3389f: Fix home link not using https.
Nathan_fraignt mentioned this in rLTAS198d193223aa: Fix home link not using https.Oct 30 2018, 11:53 AM
Nathan_fraignt mentioned this in rLTASe482dd5a3fe4: Fix home link not using https.Oct 30 2018, 11:56 AM
Nathan_fraignt mentioned this in rLTAS0b1353ae1109: Fix Home link not using https.Oct 30 2018, 12:28 PM
Nathan_fraignt mentioned this in rLTAS8fde02e23ffe: Fix Home link not using https.Oct 30 2018, 1:13 PM
xSavitar mentioned this in rLTASd30000d236a1: Fix 'Home' link not using HTTPS protocol.Oct 30 2018, 1:26 PM
gerritbot added a comment.Oct 30 2018, 1:32 PM

Change 470250 merged by jenkins-bot:
[labs/tools/awmd-stats@master] Fix 'Home' link not using HTTPS protocol

https://gerrit.wikimedia.org/r/470250

xSavitar closed this task as Resolved.Oct 30 2018, 1:39 PM
xSavitar assigned this task to Nathan_fraignt.

Thanks for working on this! Will resolve this and if it happens in the future (after deployment), we'll reopen :)

xSavitar moved this task from New Contributor's Tasks (Incoming) to Technical Tasks (Completed) on the Africa-Wikimedia-Developers board.Oct 30 2018, 1:40 PM
Liuxinyu970226 unsubscribed.Nov 2 2018, 5:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits