Maniphest T204964

Empty resultsets give broken json
Closed, ResolvedPublic
Actions

Assigned To

zhuyifei1999

Authored By

	zhuyifei1999
	Sep 20 2018, 3:16 PM

Description

Eg. https://quarry.wmflabs.org/run/291476/output/0/json:

{"rows": ], "meta": {"run_id": 291476, "query_id": 25986, "rev_id": 298641}, "headers": ["page_title"]}

Out fake list implementation is always true, and this seems to be confusing the json serializer.

Details

	Subject	Repo	Branch	Lines +/-
	output.py: Fix 'fake list' boolean value for empty generators	analytics/quarry/web	master	+11 -5

Customize query in gerrit

Related Objects

Mentioned Here: rANQW4b010770fa5d: output.py: Fix 'fake list' boolean value for empty generators

Event Timeline

zhuyifei1999 created this task.Sep 20 2018, 3:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2018, 3:16 PM

Change 461662 had a related patch set uploaded (by Zhuyifei1999; owner: Zhuyifei1999):
[analytics/quarry/web@master] output.py: Fix 'fake list' boolean value for empty generators

https://gerrit.wikimedia.org/r/461662

gerritbot added a project: Patch-For-Review.Sep 20 2018, 3:28 PM

zhuyifei1999 merged a task: T205072: Query completed, but no result is shown.Sep 21 2018, 1:36 PM

zhuyifei1999 added a subscriber: Dvorapa.

Change 461662 merged by jenkins-bot:
[analytics/quarry/web@master] output.py: Fix 'fake list' boolean value for empty generators