Page MenuHomePhabricator
Create Task
Maniphest T205250

Add class attributes to HTML elements of "subtitle"
Closed, ResolvedPublic
Actions

Description

Setup

  • MediaWiki 1.31.1 (1f664ea) 00:05, 21 September 2018
  • PHP 7.0.30-0+deb9u1 (apache2handler)
  • MariaDB 10.1.26-MariaDB-0+deb9u1
  • DisplayTitle 2.0.0 (8a726b3) 18:09, 6 December 2017

Issue
There are a minimum of two extensions working with "subtitle" and adding text to the subtitle section of a page. DisplayTitle does so without adding class attributes to the retrospective HTML elements thus not allowing for fine grained manipulation via CSS.

There is the $wgDisplayTitleHideSubtitle configuration parameter allowing to hide the subtitle added by this very extensions but there may be cases there this may not be what one would like to do with these subtitles. However doing so would also affect subtitles added by other extensions.

Details

SubjectRepoBranchLines +/-
Add class to subtitlemediawiki/extensions/DisplayTitleREL1_40+1 -6
Add class to subtitlemediawiki/extensions/DisplayTitleREL1_39+1 -6
Add class to subtitlemediawiki/extensions/DisplayTitlemaster+1 -6
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Sep 24 2018, 8:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2018, 8:42 AM
cicalese added a project: User-Cicalese.Jul 26 2019, 8:10 PM
cicalese moved this task from Inbox to Backlog on the User-Cicalese board.Jul 26 2019, 8:12 PM
cicalese triaged this task as Medium priority.Apr 12 2020, 10:25 PM
cicalese moved this task from Backlog to Feature Request on the User-Cicalese board.
gerritbot added a comment.Jul 16 2023, 4:41 PM

Change 938450 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/DisplayTitle@master] Add class to subtitle

https://gerrit.wikimedia.org/r/938450

gerritbot added a project: Patch-For-Review.Jul 16 2023, 4:41 PM
cicalese moved this task from Feature Request to Doing on the User-Cicalese board.Jul 16 2023, 4:43 PM
cicalese moved this task from Backlog to In Progress on the MediaWiki-extensions-DisplayTitle board.
cicalese moved this task from In Progress to Waiting for Merge on the MediaWiki-extensions-DisplayTitle board.Jul 16 2023, 10:53 PM
cicalese moved this task from Doing to Needs Review For Me on the User-Cicalese board.Jul 16 2023, 11:25 PM
gerritbot added a comment.Jul 17 2023, 12:18 AM

Change 938450 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@master] Add class to subtitle

https://gerrit.wikimedia.org/r/938450

cicalese mentioned this in rEDPT0fda2bba1201: Add class to subtitle.Jul 17 2023, 12:18 AM
cicalese closed this task as Resolved.Jul 17 2023, 12:25 AM
cicalese claimed this task.
cicalese moved this task from Needs Review For Me to Closed on the User-Cicalese board.
cicalese moved this task from Waiting for Merge to Closed on the MediaWiki-extensions-DisplayTitle board.
Maintenance_bot removed a project: Patch-For-Review.Jul 17 2023, 12:30 AM
gerritbot added a comment.Jul 21 2023, 9:27 PM

Change 940438 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/DisplayTitle@REL1_39] Add class to subtitle

https://gerrit.wikimedia.org/r/940438

gerritbot added a project: Patch-For-Review.Jul 21 2023, 9:27 PM

Change 940439 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/DisplayTitle@REL1_40] Add class to subtitle

https://gerrit.wikimedia.org/r/940439

gerritbot added a comment.Jul 21 2023, 9:30 PM

Change 940438 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_39] Add class to subtitle

https://gerrit.wikimedia.org/r/940438

CCicalese_WMF mentioned this in rEDPT01f6e1eca7c9: Add class to subtitle.Jul 21 2023, 9:31 PM
gerritbot added a comment.Jul 21 2023, 9:31 PM

Change 940439 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_40] Add class to subtitle

https://gerrit.wikimedia.org/r/940439

CCicalese_WMF mentioned this in rEDPT8c77a8e77644: Add class to subtitle.Jul 21 2023, 9:32 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 21 2023, 10:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL