Page MenuHomePhabricator

customised version of dberrortext not displayed
Closed, ResolvedPublic

Description

Author: happy.melon.wiki

Description:
when a dberror occurs on enwiki (almost invariably the "lock wait timeout exceeded" error), the message that displays is the default english version; despite the fact that the message has been customised on enwiki. The customised version is not overriding the default message.


Version: 1.15.x
Severity: minor

Details

Reference
bz18824

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:39 PM
bzimport set Reference to bz18824.
bzimport added a subscriber: Unknown Object (MLST).

I wouldn't be surprised that customised version cannot be fetched from database when there is database error. On the other hand aren't these stored memory?

happy.melon.wiki wrote:

Well the lock-wait-timeout has got nothing to do with the slaves, it's just a traffic jam on the master. It should still be possible to read stuff if necessary: it manages to render the rest of the skin ok. Of course, that might not be the case on systems with a single database, but even then, as you say, the message should be memcached.

I'm pretty sure we deliberately don't use the site-customized messages in the DB error since by definition if our DB access is broken it may not be safe to pull from the DB. You don't necessarily know what the problem was or what further attempts to access the backend might cause. Probably not worth the effort of poking at it, but we can LATER it for prettification.

happy.melon.wiki wrote:

*** This bug has been marked as a duplicate of bug 398 ***