Page MenuHomePhabricator

Remove Generic.PHP.DeprecatedFunctions.Deprecated from 19.x branch
Closed, ResolvedPublic

Description

Recently I ran into an issue with slimapp where tests on PHP 7.1 were failing because of a Generic.PHP.DeprecatedFunctions.Deprecated warning. This project is currently maintaining PHP 5.5 compatibility and thus can't update to a newer version of mediawiki/mediawiki-codesniffer where the Generic.PHP.DeprecatedFunctions.Deprecated sniff has already been removed. The 19.x branch is the last place where we support PHP 5.5. My quick fix was to disable the sniff in local config, but @Legoktm thought that it would be worth updating generally for other PHP 5.5 consumers.

Event Timeline

Change 476788 had a related patch set uploaded (by BryanDavis; owner: Legoktm):
[mediawiki/tools/codesniffer@19.x] Disable 'Generic.PHP.DeprecatedFunctions' sniff

https://gerrit.wikimedia.org/r/476788

Change 476788 merged by jenkins-bot:
[mediawiki/tools/codesniffer@19.x] Disable 'Generic.PHP.DeprecatedFunctions' sniff

https://gerrit.wikimedia.org/r/476788

Legoktm assigned this task to bd808.