Page MenuHomePhabricator

Revisions with hidden attributes not shown in list=usercontribs
Closed, ResolvedPublic

Description

Author: matthew.britton

Description:
For revisions with hidden attributes, prop=revisions correctly lists the visible attributes and supplies "commenthidden", "texthidden" parameters as appropriate. However, list=usercontribs does not show revisions with hidden attributes at all. [[Special:Contributions]] shows them, so the API should also be able to.


Version: unspecified
Severity: normal

Details

Reference
bz19103

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:36 PM
bzimport set Reference to bz19103.

happy.melon.wiki wrote:

That Special:Contributions shows them at all is itself a bug (bug19091). Displaying revisions where the username has been hidden, in a list where all the edits are by the same username, seems to rather defeat the object of the exercise. However, edits where only the text and/or comment has been hidden should indeed be shown with appropriate blanks.

matthew.britton wrote:

(In reply to comment #1)

That Special:Contributions shows them at all is itself a bug (bug19091).

No, that bug is about the timestamps of revisions with deleted text being linked in [[Special:Contributions]] but not in the page history. This linking is pointless as all clicking it does is show an error message saying the revision can't be displayed because it's been hidden. Displaying the revisions themselves is most definitely not a bug (unless, as you mention, the username has been hidden).

happy.melon.wiki wrote:

Ah, I see. Yes, in that case the API should definitely match the on-wiki version.

Done already in r49732 as part of the fix for bug 18554