Page MenuHomePhabricator
Create Task
Maniphest T212783

cumin: Make output path sane and flexible (was: allow to suppress output and progress bars)
Open, MediumPublic4 Estimated Story Points
Actions

Description

Tasks:

  • Decouple execution from output
  • Better store of execution results and exposition of those - api for the output of commands
    • TBD how to do this in a transport neutral way
  • Collect output into msgtree of our own when using async (group output by command and node similar to sync output)
    • Investigate if this is a reasonable thing to do given the MsgTree object and available hooks in clustershell.

Was:

Opening the task to track and fix the long-known limitation in Cumin that doesn't allow to easily suppress the executed commands' output and/or progress bars.
They should ideally be suppressed independently and or redirected to an optional file-like object.

Details

SubjectRepoBranchLines +/-
CLI/clustershell: allow to disable progress barsoperations/software/cuminmaster+31 -1
clustershell: allow to choose different reportersoperations/software/cuminmaster+349 -114
Avoid double output when running Cumin commandsoperations/cookbooksmaster+28 -69
remote: re-enable cumin's outputoperations/software/spicerackmaster+4 -13
Mark get_short_command() as private.operations/software/cuminmaster+5 -5
Introduce an interface for progress bars.operations/software/cuminmaster+98 -47
Extracting obvious reporting code to a Reporter class.operations/software/cuminmaster+234 -179
cli: in dry-run send the list of hosts to stdoutoperations/software/cuminmaster+4 -1
cli: add a -n/--no-colors optionoperations/software/cuminmaster+12 -1
remote: suppress Cumin's outputoperations/software/spicerackmaster+13 -1
Customize query in gerrit

Related Objects

Event Timeline

Volans triaged this task as Medium priority.Jan 2 2019, 2:21 PM
Volans created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2019, 2:21 PM
gerritbot subscribed.Jan 2 2019, 2:24 PM

Change 481858 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] remote: suppress Cumin's output

https://gerrit.wikimedia.org/r/481858

gerritbot added a project: Patch-For-Review.Jan 2 2019, 2:24 PM
jijiki subscribed.Feb 25 2019, 10:57 PM
gerritbot added a comment.Feb 25 2019, 11:45 PM

Change 481858 merged by Volans:
[operations/software/spicerack@master] remote: suppress Cumin's output

https://gerrit.wikimedia.org/r/481858

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:41 PM
• crusnov renamed this task from cumin: allow to suppress output and progress bars to cumin: Make ouput path sane and flexible (was: allow to suppress output and progress bars).Jul 1 2019, 3:48 PM
• crusnov claimed this task.
• crusnov updated the task description. (Show Details)
• crusnov subscribed.
Volans renamed this task from cumin: Make ouput path sane and flexible (was: allow to suppress output and progress bars) to cumin: Make output path sane and flexible (was: allow to suppress output and progress bars).May 14 2020, 3:51 PM
jcrespo mentioned this in T252172: Refactor transfer.py.May 14 2020, 4:03 PM
Privacybatm mentioned this in T252802: Improve output message readabiliy of transfer.py.May 14 2020, 5:30 PM
Privacybatm mentioned this in rOSWB74170c8ae52d: CuminExecution.py: Improve output message readabiliy of transfer.py.Sep 1 2020, 8:36 AM
gerritbot added a comment.Sep 10 2020, 2:44 PM

Change 626389 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] cli: add a -n/--no-colors option

https://gerrit.wikimedia.org/r/626389

gerritbot added a project: Patch-For-Review.Sep 10 2020, 2:44 PM

Change 626390 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] cli: in dry-run send the list of hosts to stdout

https://gerrit.wikimedia.org/r/626390

gerritbot added a comment.Sep 11 2020, 8:36 AM

Change 626389 merged by jenkins-bot:
[operations/software/cumin@master] cli: add a -n/--no-colors option

https://gerrit.wikimedia.org/r/626389

gerritbot added a comment.Sep 11 2020, 8:37 AM

Change 626390 merged by jenkins-bot:
[operations/software/cumin@master] cli: in dry-run send the list of hosts to stdout

https://gerrit.wikimedia.org/r/626390

Volans mentioned this in rCUMINb715b6c95ecd: cli: add a -n/--no-colors option.Sep 11 2020, 8:38 AM
Volans mentioned this in rCUMIN6d16ec2f12b9: cli: in dry-run send the list of hosts to stdout.
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2020, 9:10 AM
gerritbot added a comment.Sep 11 2020, 12:12 PM

Change 626660 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/software/cumin@master] Extracting obvious reporting code to a Reporter class.

https://gerrit.wikimedia.org/r/626660

gerritbot added a project: Patch-For-Review.Sep 11 2020, 12:12 PM
gerritbot added a comment.Sep 18 2020, 12:05 PM

Change 628315 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/software/cumin@master] Enable cumin EventHandler to disable output.

https://gerrit.wikimedia.org/r/628315

gerritbot added a comment.Sep 30 2020, 6:07 PM

Change 626660 merged by Gehel:
[operations/software/cumin@master] Extracting obvious reporting code to a Reporter class.

https://gerrit.wikimedia.org/r/626660

Gehel mentioned this in rCUMINd46cf8b10e67: Extracting obvious reporting code to a Reporter class..Sep 30 2020, 6:36 PM
gerritbot added a comment.Oct 2 2020, 7:29 AM

Change 631702 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/software/cumin@master] Introduce an interface for progress bars.

https://gerrit.wikimedia.org/r/631702

gerritbot added a comment.Oct 13 2020, 12:08 PM

Change 631702 merged by Gehel:
[operations/software/cumin@master] Introduce an interface for progress bars.

https://gerrit.wikimedia.org/r/631702

Gehel mentioned this in rCUMIN34bb1b8118d5: Introduce an interface for progress bars..Oct 13 2020, 1:43 PM
gerritbot added a comment.Oct 16 2020, 1:26 PM

Change 634504 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/software/cumin@master] Mark get_short_command() as private.

https://gerrit.wikimedia.org/r/634504

gerritbot added a comment.Oct 19 2020, 7:42 AM

Change 634504 merged by Gehel:
[operations/software/cumin@master] Mark get_short_command() as private.

https://gerrit.wikimedia.org/r/634504

Gehel mentioned this in rCUMINa8bb9cd0539f: Mark get_short_command() as private..Oct 19 2020, 8:18 AM
gerritbot added a comment.Nov 30 2020, 9:21 AM

Change 644175 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] remote: re-enable cumin's output

https://gerrit.wikimedia.org/r/644175

gerritbot added a comment.Nov 30 2020, 10:01 AM

Change 644175 merged by jenkins-bot:
[operations/software/spicerack@master] remote: re-enable cumin's output

https://gerrit.wikimedia.org/r/644175

Volans mentioned this in T268963: Decommission cookbook failing to update DNS.Nov 30 2020, 10:01 AM
gerritbot added a comment.Dec 1 2020, 8:49 AM

Change 644458 had a related patch set uploaded (by Volans; owner: Volans):
[operations/cookbooks@master] Avoid double output when running Cumin commands

https://gerrit.wikimedia.org/r/644458

gerritbot added a comment.Dec 1 2020, 9:19 AM

Change 644458 merged by jenkins-bot:
[operations/cookbooks@master] Avoid double output when running Cumin commands

https://gerrit.wikimedia.org/r/644458

• Kormat subscribed.Feb 19 2021, 10:23 AM
gerritbot added a comment.Apr 21 2021, 2:22 PM

Change 681692 had a related patch set uploaded (by Volans; author: Volans):

[operations/software/cumin@master] CLI/clustershell: allow to disable progress bars

https://gerrit.wikimedia.org/r/681692

gerritbot added a comment.Apr 27 2021, 5:16 PM

Change 628315 merged by jenkins-bot:

[operations/software/cumin@master] clustershell: allow to choose different reporters

https://gerrit.wikimedia.org/r/628315

gerritbot added a comment.Apr 27 2021, 5:16 PM

Change 681692 merged by jenkins-bot:

[operations/software/cumin@master] CLI/clustershell: allow to disable progress bars

https://gerrit.wikimedia.org/r/681692

Volans mentioned this in rCUMIN1fcb359141ea: clustershell: allow to choose different reporters.Apr 27 2021, 5:50 PM
Volans mentioned this in rCUMINd7e90c7bf3bd: CLI/clustershell: allow to disable progress bars.
Volans removed • crusnov as the assignee of this task.May 17 2021, 9:31 AM
Aklapper added a project: Infrastructure-Foundations.Jun 21 2021, 8:59 PM
Volans mentioned this in rCCKB3a7f9a42d195: Avoid double output when running Cumin commands.Dec 14 2022, 3:27 PM
jbond subscribed.Feb 28 2023, 4:44 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 28 2023, 5:10 PM
Aklapper edited projects, added Cumin; removed SRE-tools.May 10 2023, 11:17 AM
jcrespo subscribed.Nov 14 2023, 11:16 AM

Volans, based on your comments at T330882, the original scope I needed for transfer.py is already fullfilled. I am guessing this is just open to "improve it" beyond that in the latest, increased scope?

Volans added a comment.Nov 14 2023, 11:59 AM

yes, that's correct

jcrespo awarded a token.Nov 14 2023, 12:43 PM
Volans set the point value for this task to 4.Apr 16 2024, 9:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL